[PR #9071/a33270bc backport][3.10] Add tests for websocket close #9075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
(cherry picked from commit a33270b)
bdraco
approved these changes
Sep 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.10 #9075 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 108 108
Lines 34440 34455 +15
Branches 4093 4092 -1
=======================================
+ Hits 33670 33685 +15
Misses 575 575
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
deleted the
patchback/backports/3.10/a33270bc7c36a989acafed72ce9a2a6ab2c1bc2e/pr-9071
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #9071 as merged into master (a33270b).
This is a followup to add more coverage for #5180
It took me a while but I realized that this is behaving as expected because the client is sending a string
await ws.send_str('some data')which is never received by the server (noreceive), and the connection is closed while the message is still on the wire.Everything is working as expected, and the test was wrong.
closes #5180