Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for websocket close #9071

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Add tests for websocket close #9071

merged 1 commit into from
Sep 9, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 8, 2024 •
edited
Loading

This is a followup to add more coverage for #5180

It took me a while but I realized that this is behaving as expected because the client is sending a string await ws.send_str('some data') which is never received by the server (no receive), and the connection is closed while the message is still on the wire.

Everything is working as expected, and the test was wrong.

closes #5180

@bdraco
Add tests for websocket close
c4fe706 
This is a followup to add more coverage for #5180
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 8, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (07ce0cb) to head (c4fe706).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9071   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         107      107           
  Lines       34390    34405   +15     
  Branches     4075     4074    -1     
=======================================
+ Hits        33806    33821   +15     
  Misses        412      412           
  Partials      172      172
Flag Coverage Δ
CI-GHA 98.19% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.86% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.27% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.53% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.63% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.56% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.79% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.91% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.52% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 97.46% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.07% <100.00%> (+<0.01%) ⬆️
VM-macos 97.53% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.86% <100.00%> (+<0.01%) ⬆️
VM-windows 96.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit a33270b into master Sep 9, 2024
37 of 38 checks passed
@bdraco bdraco deleted the fix_5180 branch September 9, 2024 00:46
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 9, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/a33270bc7c36a989acafed72ce9a2a6ab2c1bc2e/pr-9071

Backported as #9075

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 9, 2024
@bdraco @patchback
Add tests for websocket close (#9071)
32406bd 
(cherry picked from commit a33270b)
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 9, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/a33270bc7c36a989acafed72ce9a2a6ab2c1bc2e/pr-9071

Backported as #9076

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Sep 9, 2024
Merged
patchback bot pushed a commit that referenced this pull request Sep 9, 2024
@bdraco @patchback
Add tests for websocket close (#9071)
0888f25 
(cherry picked from commit a33270b)
@patchback patchback bot mentioned this pull request Sep 9, 2024
Merged
bdraco pushed a commit that referenced this pull request Sep 9, 2024
@patchback
[PR #9071/a33270bc backport][3.10] Add tests for websocket close (#9075)
5b2b77d 
Co-authored-by: J. Nick Koston <nick@koston.org>
closes #5180
bdraco pushed a commit that referenced this pull request Sep 9, 2024
@patchback
[PR #9071/a33270bc backport][3.11] Add tests for websocket close (#9076)
9587c45 
Co-authored-by: J. Nick Koston <nick@koston.org>
closes #5180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strange WebSocket behavior since version 3.7
1 participant
@bdraco