Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5344/bff76313 backport][3.11] Fix StreamResponse.prepared not returning True after EOF is sent #8894

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Aug 26, 2024

This is a backport of PR #5344 as merged into master (bff7631).

Fixes #5343

I renamed a few tests (i think the prepared attribute used to be named started and the tests were not renamed?)
And I removed some asserts around prepare in a test___repr__ test - to move them to a dedicated test

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3.11@996204a). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #8894   +/-   ##
=======================================
  Coverage        ?   97.70%           
=======================================
  Files           ?      108           
  Lines           ?    34202           
  Branches        ?     4064           
=======================================
  Hits            ?    33417           
  Misses          ?      586           
  Partials        ?      199           
Flag Coverage Δ
CI-GHA 97.60% <100.00%> (?)
OS-Linux 97.27% <100.00%> (?)
OS-Windows 94.82% <100.00%> (?)
OS-macOS 96.97% <100.00%> (?)
Py-3.10.11 97.05% <100.00%> (?)
Py-3.10.14 96.98% <100.00%> (?)
Py-3.11.9 97.22% <100.00%> (?)
Py-3.12.4 94.63% <100.00%> (?)
Py-3.12.5 97.02% <100.00%> (?)
Py-3.9.13 96.96% <100.00%> (?)
Py-3.9.19 96.89% <100.00%> (?)
Py-pypy7.3.16 96.48% <100.00%> (?)
VM-macos 96.97% <100.00%> (?)
VM-ubuntu 97.27% <100.00%> (?)
VM-windows 94.82% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit b2e1294 into 3.11 Aug 26, 2024
30 of 31 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.11/bff76313298d8b2c7539f9dc496801ee86ab7097/pr-5344 branch August 26, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants