Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StreamResponse.prepared not returning True after EOF is sent #5344

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Fix StreamResponse.prepared not returning True after EOF is sent #5344

merged 4 commits into from
Aug 26, 2024

Conversation

arthurdarcet
Copy link
Contributor

@arthurdarcet arthurdarcet commented Dec 14, 2020 •
edited by Dreamsorcerer
Loading

Fixes #5343

I renamed a few tests (i think the prepared attribute used to be named started and the tests were not renamed?)
And I removed some asserts around prepare in a test___repr__ test - to move them to a dedicated test

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 14, 2020
@codecov
Copy link

codecov bot commented Dec 14, 2020 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (48a5e07) to head (606d5bc).
Report is 1059 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5344      +/-   ##
==========================================
- Coverage   98.24%   98.23%   -0.01%     
==========================================
  Files         107      107              
  Lines       34110    34114       +4     
  Branches     4049     4049              
==========================================
+ Hits        33511    33513       +2     
- Misses        423      424       +1     
- Partials      176      177       +1
Flag Coverage Δ
CI-GHA 98.13% <100.00%> (-0.01%) ⬇️
OS-Linux 97.79% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.19% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.46% <100.00%> (-0.02%) ⬇️
Py-3.10.11 97.56% <100.00%> (-0.01%) ⬇️
Py-3.10.14 97.49% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.72% <100.00%> (+<0.01%) ⬆️
Py-3.12.4 95.99% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.52% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.45% <100.00%> (-0.02%) ⬇️
Py-3.9.19 97.39% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.00% <100.00%> (+<0.01%) ⬆️
VM-macos 97.46% <100.00%> (-0.02%) ⬇️
VM-ubuntu 97.79% <100.00%> (+<0.01%) ⬆️
VM-windows 96.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer added backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Aug 24, 2024
@Dreamsorcerer
Copy link
Member

This PR seems to have been missed. Thanks @arthurdarcet.

@bdraco bdraco changed the title StreamResponse.prepared returns True even after EOF is sent (fixes #5343) StreamResponse.prepared returns True even after EOF is sent Aug 24, 2024
@bdraco bdraco changed the title StreamResponse.prepared returns True even after EOF is sent Fix StreamResponse.prepared not returning True after EOF is sent Aug 24, 2024
@Dreamsorcerer Dreamsorcerer removed the bot:chronographer:provided There is a change note present in this PR label Aug 26, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 26, 2024
@Dreamsorcerer Dreamsorcerer merged commit bff7631 into aio-libs:master Aug 26, 2024
37 of 39 checks passed
@patchback Patchback
Copy link
Contributor

patchback bot commented Aug 26, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/bff76313298d8b2c7539f9dc496801ee86ab7097/pr-5344

Backported as #8893

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 26, 2024
@arthurdarcet @patchback
Fix StreamResponse.prepared not returning True after EOF is sent (#5344)
962b854 
(cherry picked from commit bff7631)
@patchback patchback bot mentioned this pull request Aug 26, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Aug 26, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/bff76313298d8b2c7539f9dc496801ee86ab7097/pr-5344

Backported as #8894

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 26, 2024
@arthurdarcet @patchback
Fix StreamResponse.prepared not returning True after EOF is sent (#5344)
d6ebd9a 
(cherry picked from commit bff7631)
@patchback patchback bot mentioned this pull request Aug 26, 2024
Merged
Dreamsorcerer pushed a commit that referenced this pull request Aug 26, 2024
@patchback
[PR #5344/bff76313 backport][3.11] Fix StreamResponse.prepared not re…
b2e1294 
…turning True after EOF is sent (#8894)

**This is a backport of PR #5344 as merged into master
(bff7631).**
Dreamsorcerer pushed a commit that referenced this pull request Aug 26, 2024
@patchback @arthurdarcet
[PR #5344/bff76313 backport][3.10] Fix StreamResponse.prepared not re…
b78cef3 
…turning True after EOF is sent (#8893)

**This is a backport of PR #5344 as merged into master
(bff7631).**

Co-authored-by: Arthur Darcet <arthur@glose.com>
@booniepepper booniepepper mentioned this pull request Sep 3, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web_response.Response.prepared is False after write_eof()
3 participants
@arthurdarcet @Dreamsorcerer @bdraco