Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8742/b4f9cb35 backport][3.11] Fix status not being set when ClientResponse.json raises ContentTypeError #8746

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Aug 19, 2024

This is a backport of PR #8742 as merged into master (b4f9cb3).

What do these changes do?

Fix status not being set when ClientResponse.json raises ContentTypeError

Are there changes in behavior for the user?

The status will be set

Is it a substantial burden for the maintainers to support this?

no

Related issue number

fixes #8741

@bdraco bdraco enabled auto-merge (squash) August 19, 2024 16:42
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3.11@9a03467). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #8746   +/-   ##
=======================================
  Coverage        ?   97.69%           
=======================================
  Files           ?      108           
  Lines           ?    34166           
  Branches        ?     4063           
=======================================
  Hits            ?    33380           
  Misses          ?      587           
  Partials        ?      199           
Flag Coverage Δ
CI-GHA 97.59% <100.00%> (?)
OS-Linux 97.26% <100.00%> (?)
OS-Windows 94.80% <100.00%> (?)
OS-macOS 96.93% <100.00%> (?)
Py-3.10.11 97.02% <100.00%> (?)
Py-3.10.14 96.97% <100.00%> (?)
Py-3.11.9 97.21% <100.00%> (?)
Py-3.12.4 97.30% <100.00%> (?)
Py-3.8.10 94.44% <100.00%> (?)
Py-3.8.18 96.78% <100.00%> (?)
Py-3.9.13 96.93% <100.00%> (?)
Py-3.9.19 96.89% <100.00%> (?)
Py-pypy7.3.16 96.48% <100.00%> (?)
VM-macos 96.93% <100.00%> (?)
VM-ubuntu 97.26% <100.00%> (?)
VM-windows 94.80% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 096bc9d into 3.11 Aug 19, 2024
30 of 31 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/b4f9cb35589db813bd449b9475ad039cc49ee9c1/pr-8742 branch August 19, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant