Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix status not being set when ClientResponse.json raises ContentTypeError #8742

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Fix status not being set when ClientResponse.json raises ContentTypeError #8742

merged 5 commits into from
Aug 19, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 19, 2024

What do these changes do?

Fix status not being set when ClientResponse.json raises ContentTypeError

Are there changes in behavior for the user?

The status will be set

Is it a substantial burden for the maintainers to support this?

no

Related issue number

fixes #8741

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 19, 2024
@bdraco bdraco added backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Aug 19, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (1eb6519) to head (040e0f5).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8742   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         107      107           
  Lines       34062    34064    +2     
  Branches     4029     4029           
=======================================
+ Hits        33430    33432    +2     
  Misses        456      456           
  Partials      176      176
Flag Coverage Δ
CI-GHA 98.04% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.69% <100.00%> (-0.01%) ⬇️
OS-Windows 96.07% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.35% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.44% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.38% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.62% <100.00%> (-0.01%) ⬇️
Py-3.12.4 97.73% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 95.71% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 97.21% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.35% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 97.30% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 96.91% <100.00%> (+<0.01%) ⬆️
VM-macos 97.35% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.69% <100.00%> (-0.01%) ⬇️
VM-windows 96.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review August 19, 2024 16:29
@bdraco bdraco merged commit b4f9cb3 into master Aug 19, 2024
37 of 38 checks passed
@bdraco bdraco deleted the status_not_set_content_type_error branch August 19, 2024 16:42
@patchback Patchback
Copy link
Contributor

patchback bot commented Aug 19, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/b4f9cb35589db813bd449b9475ad039cc49ee9c1/pr-8742

Backported as #8745

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 19, 2024
@bdraco @patchback
Fix status not being set when ClientResponse.json raises ContentTypeE…
c6c9917 
…rror (#8742)

(cherry picked from commit b4f9cb3)
@patchback patchback bot mentioned this pull request Aug 19, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Aug 19, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/b4f9cb35589db813bd449b9475ad039cc49ee9c1/pr-8742

Backported as #8746

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 19, 2024
@bdraco @patchback
Fix status not being set when ClientResponse.json raises ContentTypeE…
bc2aa87 
…rror (#8742)

(cherry picked from commit b4f9cb3)
@patchback patchback bot mentioned this pull request Aug 19, 2024
Merged
bdraco pushed a commit that referenced this pull request Aug 19, 2024
@patchback
[PR #8742/b4f9cb35 backport][3.10] Fix status not being set when Clie…
c7ff47b 
…ntResponse.json raises ContentTypeError (#8745)

Co-authored-by: J. Nick Koston <nick@koston.org>
fixes #8741
bdraco pushed a commit that referenced this pull request Aug 19, 2024
@patchback
[PR #8742/b4f9cb35 backport][3.11] Fix status not being set when Clie…
096bc9d 
…ntResponse.json raises ContentTypeError (#8746)

Co-authored-by: J. Nick Koston <nick@koston.org>
fixes #8741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClientResponse.json() doesn't set status code
1 participant
@bdraco