-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change typing of the secure argument on StreamResponse.set_cookie #4238
Conversation
…m Optional[str] to a Optional[bool]
Codecov Report
@@ Coverage Diff @@
## master #4238 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 43 43
Lines 8841 8841
Branches 1383 1383
=======================================
Hits 8625 8625
Misses 93 93
Partials 123 123
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update ./docs/web_reference.rst
as well
@asvetlov I think docs are correct already, aren't they? It was only the typings that were wrong. https://docs.aiohttp.org/en/stable/web_reference.html#aiohttp.web.BaseRequest.secure |
There is also https://docs.aiohttp.org/en/stable/web_reference.html#aiohttp.web.StreamResponse.set_cookie where types for parameters are outdated for |
I updated |
Thanks! |
What do these changes do?
This change fixes the contradiction between docs and annotation in code
Are there changes in behavior for the user?
No
Related issue number
This commit fixes #4204
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.