Change typing of the secure argument on StreamResponse.set_cookie (#4238

)
aio-libs · Oct 26, 2019 · e4573f8 · e4573f8
1 parent 7f77733
commit e4573f8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGES/4204.doc b/CHANGES/4204.doc
@@ -0,0 +1 @@
+Change typing of the secure argument on StreamResponse.set_cookie from Optional[str] to a Optional[bool]
diff --git a/aiohttp/web_response.py b/aiohttp/web_response.py
@@ -169,8 +169,8 @@ def set_cookie(self, name: str, value: str, *,
                    domain: Optional[str]=None,
                    max_age: Optional[Union[int, str]]=None,
                    path: str='/',
-                   secure: Optional[str]=None,
-                   httponly: Optional[str]=None,
+                   secure: Optional[bool]=None,
+                   httponly: Optional[bool]=None,
                    version: Optional[str]=None) -> None:
         """Set or update response cookie.