Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests that don't throw DeprecationWarning #3738

Merged
merged 3 commits into from
May 10, 2019
Merged

Fix tests that don't throw DeprecationWarning #3738

merged 3 commits into from
May 10, 2019

Conversation

atemate
Copy link
Contributor

@atemate atemate commented May 7, 2019

Fixed two old tests that assert throwing DeprecationWarning whereas in fact the AttributeError is raised. These tests start to be wrong since the RequestHandler.__slots__ were implemented (see #3095).

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@atemate atemate requested a review from asvetlov as a code owner May 7, 2019 21:43
@codecov-io
Copy link

codecov-io commented May 7, 2019

Codecov Report

Merging #3738 into master will decrease coverage by 3.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3738      +/-   ##
==========================================
- Coverage   97.89%   94.82%   -3.08%     
==========================================
  Files          43       43              
  Lines        8558     8557       -1     
  Branches     1377     1376       -1     
==========================================
- Hits         8378     8114     -264     
- Misses         75      338     +263     
  Partials      105      105
Impacted Files Coverage Δ
aiohttp/worker.py 6.55% <0%> (-90.99%) ⬇️
aiohttp/resolver.py 46.55% <0%> (-53.45%) ⬇️
aiohttp/web_fileresponse.py 66.66% <0%> (-29.89%) ⬇️
aiohttp/tcp_helpers.py 63.33% <0%> (-26.67%) ⬇️
aiohttp/locks.py 92.85% <0%> (-7.15%) ⬇️
aiohttp/web_runner.py 91.7% <0%> (-6.22%) ⬇️
aiohttp/__init__.py 94.44% <0%> (-5.56%) ⬇️
aiohttp/http_parser.py 93.11% <0%> (-4.82%) ⬇️
aiohttp/http_writer.py 95.28% <0%> (-2.84%) ⬇️
aiohttp/frozenlist.py 97.87% <0%> (-2.13%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db80171...a69d101. Read the comment docs.

@asvetlov
Copy link
Member

asvetlov commented May 8, 2019

please drop unused imports

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ asvetlov
❌ ayushkovskiy
You have signed the CLA already but the status is still pending? Let us recheck it.

@asvetlov asvetlov merged commit 74a46a5 into aio-libs:master May 10, 2019
@lock lock bot added the outdated label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants