Fix tests that don't throw DeprecationWarning (#3738)

aio-libs · May 10, 2019 · 74a46a5 · 74a46a5
1 parent ee2951f
commit 74a46a5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/tests/test_client_session.py b/tests/test_client_session.py
@@ -16,7 +16,7 @@
 from aiohttp.client import ClientSession
 from aiohttp.client_reqrep import ClientRequest
 from aiohttp.connector import BaseConnector, TCPConnector
-from aiohttp.helpers import DEBUG, PY_36
+from aiohttp.helpers import PY_36
 
 
 @pytest.fixture
@@ -663,11 +663,9 @@ class A(ClientSession):
             pass
 
 
-@pytest.mark.skipif(not DEBUG,
-                    reason="The check is applied in DEBUG mode only")
 async def test_client_session_custom_attr(loop) -> None:
     session = ClientSession(loop=loop)
-    with pytest.warns(DeprecationWarning):
+    with pytest.raises(AttributeError):
         session.custom = None
 
 

diff --git a/tests/test_web_app.py b/tests/test_web_app.py
@@ -6,7 +6,7 @@
 
 from aiohttp import log, web
 from aiohttp.abc import AbstractAccessLogger
-from aiohttp.helpers import DEBUG, PY_36
+from aiohttp.helpers import PY_36
 from aiohttp.test_utils import make_mocked_coro
 
 
@@ -280,11 +280,9 @@ class A(web.Application):
             pass
 
 
-@pytest.mark.skipif(not DEBUG,
-                    reason="The check is applied in DEBUG mode only")
 def test_app_custom_attr() -> None:
     app = web.Application()
-    with pytest.warns(DeprecationWarning):
+    with pytest.raises(AttributeError):
         app.custom = None