[PR #11972/4a51c4ba backport][3.14] NEEDS_CLEANUP_CLOSED fixed in Python 3.12.8

[patchback]

This is a backport of PR #11972 as merged into master (4a51c4b).

What do these changes do?

According to https://docs.python.org/3.12/whatsnew/changelog.html#python-3-12-8-final the fix for gh-118950 landed in Python 3.12.8 not 3.12.7 as the code and the comment states. This is also in line with when the fix's backport was merged, which was after 3.12.7 was released.

Are there changes in behavior for the user?

Yes. The change will suppress a false-positive deprecation warning.

Is it a substantial burden for the maintainers to support this?

No. The code was there before. It's just a fix.

Related issue number

None

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES/ folder

  • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

  • if you don't have an issue number, change it to the pull request
    number after creating the PR

    • .bugfix: A bug fix for something the maintainers deemed an
      improper undesired behavior that got corrected to match
      pre-agreed expectations.
    • .feature: A new behavior, public APIs. That sort of stuff.
    • .deprecation: A declaration of future API removals and breaking
      changes in behavior.
    • .breaking: When something public is removed in a breaking way.
      Could be deprecated in an earlier release.
    • .doc: Notable updates to the documentation structure or build
      process.
    • .packaging: Notes for downstreams about unobvious side effects
      and tooling. Changes in the test invocation considerations and
      runtime assumptions.
    • .contrib: Stuff that affects the contributor experience. e.g.
      Running tests, building the docs, setting up the development
      environment.
    • .misc: Changes that are hard to assign to any of the above
      categories.

  • Make sure to use full sentences with correct case and punctuation,
    for example:

    Fixed issue with non-ascii contents in doctest text files
    -- by :user:`contributor-gh-handle`.

    Use the past tense or the present tense a non-imperative mood,
    referring to what's changed compared to the last released version
    of this project.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (3.14@d3405d9). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             3.14   #11976   +/-   ##
=======================================
  Coverage        ?   98.21%           
=======================================
  Files           ?      128           
  Lines           ?    44990           
  Branches        ?     2434           
=======================================
  Hits            ?    44189           
  Misses          ?      618           
  Partials        ?      183           

Flag	Coverage Δ
CI-GHA	98.09% <ø> (?)
OS-Linux	97.85% <ø> (?)
OS-Windows	95.60% <ø> (?)
OS-macOS	97.10% <ø> (?)
Py-3.10.11	96.64% <ø> (?)
Py-3.10.19	97.13% <ø> (?)
Py-3.11.14	97.37% <ø> (?)
Py-3.11.9	96.88% <ø> (?)
Py-3.12.10	96.97% <ø> (?)
Py-3.12.12	97.46% <ø> (?)
Py-3.13.11	97.69% <ø> (?)
Py-3.14.2	97.66% <ø> (?)
Py-3.14.2t	96.77% <ø> (?)
Py-pypy3.11.13-7.3.20	96.91% <ø> (?)
VM-macos	97.10% <ø> (?)
VM-ubuntu	97.85% <ø> (?)
VM-windows	95.60% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing patchback/backports/3.14/4a51c4ba30b886b5d1505e4aed790df0cc7cd8d2/pr-11972 (e8d085d) with 3.14 (30ec25f)¹}

Summary

✅ 59 untouched benchmarks

Footnotes

1. No successful run was found on 3.14 (d3405d9) during the generation of this report, so 30ec25f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩