NEEDS_CLEANUP_CLOSED fixed in Python 3.12.8 - #11972
Conversation
According to https://docs.python.org/3.12/whatsnew/changelog.html#python-3-12-8-final the fix for gh-118950 landed in Python 3.12.8 not 3.12.7 as the code and the comment states. This is also in line with when the fix's backport was merged, which was after 3.12.7 was released.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11972 +/- ##
==========================================
- Coverage 98.76% 98.75% -0.01%
==========================================
Files 127 127
Lines 44655 44655
Branches 2367 2367
==========================================
- Hits 44102 44099 -3
- Misses 393 396 +3
Partials 160 160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
psf-chronographer
Bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
|
Test failure appears to be unrelated, please double-check. |
Dreamsorcerer
added
backport-3.13
backport-3.14
Backport to 3.13: 💚 backport PR created✅ Backport PR branch: Backported as #11975 🤖 @patchback |
(cherry picked from commit 4a51c4b)
Backport to 3.14: 💚 backport PR created✅ Backport PR branch: Backported as #11976 🤖 @patchback |
(cherry picked from commit 4a51c4b)
…d in Python 3.12.8 (aio-libs#11975) **This is a backport of PR aio-libs#11972 as merged into master (af903ef).** Co-authored-by: Robsdedude <dev@rouvenbauer.de>
2 participants
What do these changes do?
According to https://docs.python.org/3.12/whatsnew/changelog.html#python-3-12-8-final the fix for gh-118950 landed in Python 3.12.8 not 3.12.7 as the code and the comment states. This is also in line with when the fix's backport was merged, which was after 3.12.7 was released.
Are there changes in behavior for the user?
Yes. The change will suppress a false-positive deprecation warning.
Is it a substantial burden for the maintainers to support this?
No. The code was there before. It's just a fix.
Related issue number
None
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.