Merge pull request #856 from samuelcolvin/static-file-error-fix

'request.logger' > 'request.app.logger' in StaticFileMixin
aio-libs · Jun 2, 2016 · 3664464 · 3664464
2 parents b696364 + c9b7169
commit 3664464
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/aiohttp/web_urldispatcher.py b/aiohttp/web_urldispatcher.py
@@ -566,7 +566,7 @@ def handle(self, request):
             raise HTTPNotFound() from error
         except Exception as error:
             # perm error or other kind!
-            request.logger.exception(error)
+            request.app.logger.exception(error)
             raise HTTPNotFound() from error
 
         st = filepath.stat()

diff --git a/tests/test_web_functional.py b/tests/test_web_functional.py
@@ -836,6 +836,10 @@ def go(dirname, filename):
             self.assertEqual(404, resp.status)
             resp.close()
 
+            resp = yield from request('GET', url + 'x' * 500, loop=self.loop)
+            self.assertEqual(404, resp.status)
+            resp.close()
+
             resp = yield from request('GET', url + '/../../', loop=self.loop)
             self.assertEqual(404, resp.status)
             resp.close()