Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'request.logger' > 'request.app.logger' in StaticFileMixin #856

Merged
merged 1 commit into from
Jun 2, 2016
Merged

'request.logger' > 'request.app.logger' in StaticFileMixin #856

merged 1 commit into from
Jun 2, 2016

Conversation

samuelcolvin
Copy link
Member

(I believe this error exists on master too, but i'm using 0.21 as base as per the instructions).

What these changes does?

prevent 500 exception with extremely long url requests to the static file router.

This is a slightly ugly way of getting the error to occur, presumably there are other causes of a suitable exception, but this how I found the error and seems to demonstrate the point.

The code causing the error was not previously covered.

How to test your changes?

see test below

Checklist

  • Code is written and well
  • Tests for the changes are provided
  • Documentation reflects the changes

@coveralls
Copy link

coveralls commented May 2, 2016

Coverage Status

Coverage decreased (-1.1%) to 97.262% when pulling 82e7d45 on samuelcolvin:static-file-error-fix into 63cf125 on KeepSafe:0.21.

@coveralls
Copy link

coveralls commented May 2, 2016

Coverage Status

Coverage increased (+0.05%) to 98.454% when pulling c9b7169 on samuelcolvin:static-file-error-fix into 63cf125 on KeepSafe:0.21.

@samuelcolvin
Copy link
Member Author

@asvetlov any chance of merging this? I see it's still broken in master too.

@asvetlov asvetlov merged commit 3664464 into aio-libs:0.21 Jun 2, 2016
@asvetlov
Copy link
Member

asvetlov commented Jun 2, 2016

Thanks

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants