refactor: split up base class #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domire8
force-pushed
the
feat/controllers-base-2
branch
from
90a5122 to
113859d
Compare
bpapaspyros
approved these changes
Aug 30, 2024
bpapaspyros
left a comment
bpapaspyros
left a comment
There was a problem hiding this comment.
I hope I am not missing something in the big diff, but as far as I see this looks good!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
modulo_controllers::ControllerInterfacein non biased and biased classes #135As the issue states, this PR splits up the base class into a
BaseControllerInterfacewhich only adds modulo publishers, signals and services to the ros2 control controller interface and into aControllerInterfacewhich is very biased to how we would propose to design controllers.The diff is quite big but I essentially just moved some code around..
Review guidelines
Estimated Time of Review: 10 minutes
Checklist before merging: