fix: update nixl arm build for other frameworks

[nv-anants]

Apply changes from #1544 to other dockerfiles

Summary by CodeRabbit

• Refactor
  • Simplified and unified build and installation steps for the NIXL component across all architectures in multiple Dockerfiles by removing architecture-specific configuration and conditional logic.

[coderabbitai]

Walkthrough

The changes unify the build and installation steps for the NIXL component across all Dockerfiles by removing architecture-specific conditional logic. All architecture-dependent flags and conditions for both the Meson setup and Python module installation are eliminated, resulting in a single, unconditional build and install process for every architecture.

Changes

Files	Change Summary
container/Dockerfile.sglang, container/Dockerfile.tensorrt_llm, container/Dockerfile.vllm_v1	Removed architecture-specific conditionals for NIXL build and installation; unified commands for all architectures.

Sequence Diagram(s)

sequenceDiagram
    participant Dockerfile
    participant Meson
    participant Ninja
    participant Python (uv pip)

    Dockerfile->>Meson: meson setup (no arch-specific flags)
    Meson-->>Dockerfile: Setup complete
    Dockerfile->>Ninja: ninja -C build
    Ninja-->>Dockerfile: Build complete
    Dockerfile->>Ninja: ninja -C build install
    Ninja-->>Dockerfile: Install complete
    Dockerfile->>Python (uv pip): uv pip install (no arch-specific settings)
    Python (uv pip)-->>Dockerfile: Python module installed

Loading

Possibly related PRs

• fix: update nixl build and keep wheels dir in vllm container #1544: Removes architecture-specific conditional logic for building and installing NIXL, directly aligning with the changes in this PR.

Poem

In Dockerfiles, the flags once danced,
"If arm64, then do this!" they chanced.
Now all are equal, the build is one,
No more branches—just simple fun!
NIXL compiles with unity's song,
The rabbit hops—no flags gone wrong! 🐇

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 65f2de5 and 113867f.

📒 Files selected for processing (3)

• container/Dockerfile.sglang (2 hunks)
• container/Dockerfile.tensorrt_llm (1 hunks)
• container/Dockerfile.vllm_v1 (2 hunks)

🔇 Additional comments (5)

container/Dockerfile.tensorrt_llm (1)

105-110: Unify NIXL build command across architectures
The Meson setup now runs unconditionally, removing ARM-specific flags and simplifying maintenance.

container/Dockerfile.vllm_v1 (2)

123-128: Simplify NIXL Meson setup by removing ARM-specific -Dgds_path flag
The build step maintains --buildtype=release and now applies uniformly across architectures.

---

155-155: Unify NIXL Python wheel installation
Replaced conditional wheel build commands with a single uv build invocation, streamlining multi-architecture installs.

container/Dockerfile.sglang (2)

88-93: Remove conditional logic for NIXL Meson setup
The Meson setup is now architecture-agnostic, simplifying the build pipeline and aligning with other Dockerfiles.

---

120-120: Streamline NIXL Python module installation
Unified the uv pip install command to remove architecture-dependent options.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.