fix: update nixl build and keep wheels dir in vllm container

[nv-anants]

Overview:

• NIXL now supports arm builds, so no need to pass in gds-path args. Ref: ai-dynamo/nixl@2a88836
• Do not delete wheelhouse directory from runtime container, need it in CI

closes: OPS-272, OPS-273

Summary by CodeRabbit

• Chores
  • Simplified the build and installation process for all architectures, removing architecture-specific logic.
  • Standardized build commands and configuration across platforms.
  • The wheelhouse directory is now retained after installation, instead of being deleted.

[coderabbitai]

Walkthrough

This change simplifies the Dockerfile for the vllm container by removing architecture-specific build steps and configuration flags for building and installing the NIXL component. All architectures now use the same Meson build commands, and the cleanup step for the wheelhouse directory is omitted after wheel installation.

Changes

File(s)	Change Summary
container/Dockerfile.vllm	Removed architecture-specific logic and flags from NIXL build/install steps; omitted wheelhouse cleanup.

Sequence Diagram(s)

sequenceDiagram
    participant Docker as Docker Build
    participant Meson as Meson Build
    participant Python as Python Wheel Install

    Docker->>Meson: Run meson setup (no arch-specific flags)
    Meson-->>Docker: Build NIXL native code
    Docker->>Python: Build and install NIXL Python wheel
    Python-->>Docker: Wheel installed (wheelhouse remains)

Loading

Possibly related PRs

• build: fixes to enable vLLM slim runtime image #1058: Restructures the NIXL build and installation flow to use wheel artifacts with architecture-specific handling, modifying a similar build/install process.
• feat: Update container with better EFA/RDMA support #1333: Modifies the Dockerfile to add RDMA-related packages and introduces a build argument for UCX versioning, also changing the NIXL Meson build configuration.

Poem

In the Docker burrow, code hops anew,
No more branches for arm or for x86 to pursue.
Meson builds are simple, the flags all the same,
Wheels installed gently, wheelhouse remains.
A rabbit’s delight—less clutter, less fuss,
Unified builds make for a happier us! 🐇

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

container/Dockerfile.vllm (1)

523-523: Review broad binary symlinks—limit to needed executables
Symlinking all files from the venv into /usr/local/bin may overshadow system binaries or include unintended tools. Consider restricting links to only required CLI executables to avoid conflicts.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 47d05d7 and 67cedb3.

📒 Files selected for processing (1)

• container/Dockerfile.vllm (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: pre-commit

🔇 Additional comments (2)

container/Dockerfile.vllm (2)

123-128: Unify NIXL build commands—verify ARM build compatibility
The removal of architecture‐specific -Dgds_path flags simplifies the Meson build. Please ensure this unified setup succeeds on both x86_64 and aarch64 and that GPU Direct Storage support is correctly detected without explicit paths.

---

155-155: Consolidated Python wheel build—validate output
Using uv build to produce the NIXL wheel in /workspace/wheels/nixl is a clean approach. Confirm that the wheel is correctly tagged for all target platforms and Python versions (e.g., manylinux compatibility on ARM).