Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a trailing newline to package.json when appropriate #17

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Add a trailing newline to package.json when appropriate #17

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca77baa
add a trailing newline
blink1073 Nov 14, 2022
d67c1f7
Update hatch_nodejs_version/version_source.py
blink1073 Nov 14, 2022
870a705
adjust workflow triggers
blink1073 Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion hatch_nodejs_version/version_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,15 @@ def set_version(self, version: str, version_data):
if not os.path.isfile(path):
raise OSError(f"file does not exist: {self.path}")

# Read the original file so we can see if it has a trailing
# newline character.
with open(path, "r") as f:
data = json.load(f)
raw_data = f.read()

data = json.loads(raw_data)

data["version"] = self.python_version_to_node(version)
with open(path, "w") as f:
json.dump(data, f, indent=4)
if raw_data.endswith('\n'):
f.write('\n')