Add a trailing newline to package.json when appropriate #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
reviewed
Nov 14, 2022
Co-authored-by: Angus Hollands <goosey15@gmail.com>
|
Hmm, not sure why the actions aren't running, there is no current GitHub incident, supposedly. |
|
Ah, they're set to only run on push. |
|
Mind if I tweak it to run on PRs to master as well? |
|
Haha, we're making the same change! You're welcome to do that, I'll hold off. |
agoose77
approved these changes
Nov 14, 2022
|
I copied what we have in |
|
Do you want to make a new release? I'm happy to, but you're welcome to ;) |
|
I'm happy to release, if you add |
|
Oh! I had thought that I'd already done this for you an @fcollonval. Done. |
|
Released! |
Thanks @agoose77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing failures in maintainer-tools, which uses the
end-of-file-fixerpre-commit hook.Npm and Yarn also typically add a newline character to the file when interacting with it.