Skip to content

fix(sandbox): preserve zero exit code in E2B JSON stream #2609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ump45nose wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(sandbox): preserve zero exit code in E2B JSON stream #2609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...-sandbox-e2b/src/main/java/io/agentscope/extensions/sandbox/e2b/E2bEnvdProcessClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ private int drainStartStream(
DynamicMessage end = (DynamicMessage) pe.getField(peEndF);
Descriptors.FieldDescriptor ec =
end.getDescriptorForType().findFieldByName("exit_code");
if (end.hasField(ec)) {
if (ec != null) {
Object v = end.getField(ec);
exit = v instanceof Integer ? (Integer) v : ((Long) v).intValue();
}
Expand Down Expand Up @@ -344,8 +344,6 @@ private DynamicMessage parseJsonStartResponse(byte[] data) throws IOException {
JsonNode exitCodeNode = endNode.path("exitCode");
if (exitCodeNode.canConvertToInt()) {
endBuilder.setField(exitCodeField, exitCodeNode.intValue());
}
if (!endBuilder.getAllFields().isEmpty()) {
event.setField(processEventDesc.findFieldByName("end"), endBuilder.build());
}
}
Expand Down
11 changes: 11 additions & 0 deletions ...dbox-e2b/src/test/java/io/agentscope/extensions/sandbox/e2b/E2bEnvdProcessClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,17 @@ void jsonCodecReturnsEmptyOutputsWhenOnlyEndPresent() throws Exception {
assertEquals("", stderr.toString(StandardCharsets.UTF_8));
}

@Test
void jsonCodecPreservesZeroExitCode() throws Exception {
E2bEnvdProcessClient client = new E2bEnvdProcessClient(options(E2bCodec.JSON));
ByteArrayOutputStream stdout = new ByteArrayOutputStream();
ByteArrayOutputStream stderr = new ByteArrayOutputStream();
int exit =
drainStartStream(client, connectFrame(responseJson(null, null, 0)), stdout, stderr);

assertEquals(0, exit);
}

private static DynamicMessage dataResponse(
E2bEnvdProcessClient client, String stdout, String stderr) {
Descriptors.FileDescriptor fd = client.fileDescriptor();
Expand Down
Loading