fix(sandbox): preserve zero exit code in E2B JSON stream - #2609
Draft
ump45nose wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.0.1-SNAPSHOT
Description
Fixes #2603.
In
E2bCodec.JSONmode, an explicit{"end":{"exitCode":0}}frame was lost twice because proto3 does not include default scalar values ingetAllFields()and reports no scalar presence throughhasField(). As a result, successful commands kept the missing-exit sentinel and failed.This change:
endevent when an integerexitCodewas explicitly parsed, including zero;Related duplicate reports: #2601, #2602.
Tested with:
Result: 8 tests passed, including
jsonCodecPreservesZeroExitCode.Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:apply