Repository navigation
Support default egress policies in ActorTemplates - #1558
Closed
Eitan Yarmush (EItanya) wants to merge 4 commits into
Closed
Eitan Yarmush (EItanya) wants to merge 4 commits into
Eitan Yarmush (EItanya) wants to merge 4 commits into
Conversation
Allow actor templates to supply metadata-free initial egress rules, validated like actor egress policies. Copy them into a default policy in the actor creation transaction so policy write failures cannot leave an actor without its configured policy. Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Use one CreateActor store operation for actors with or without an initial policy, preserving transactional writes when a policy is supplied. Update callers to pass nil when no policy is needed and remove redundant service wiring. Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Eitan Yarmush (EItanya)
requested a review
from Julian Gutierrez Oschmann (juli4n)
September 9, 2026 20:05
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Collaborator
Collaborator
|
hmmm - plus one on having support for actor default egress policies. But I think our controller / egress policy implementation should just be deny-by-default regardless if the api has the policy within the actor. Its kinda orthogonal but wanted to make sure we are on the same page that we dont want to couple having that default empty egress policy in order to trigger deny by default |
haiyanmeng
reviewed
Sep 11, 2026
|
|
||
| // Initial egress policy, copied atomically when an Actor is created from | ||
| // this template. The policy is named "default" in the Actor's atespace. | ||
| // Later template changes do not affect existing Actors' policies, which |
Collaborator
There was a problem hiding this comment.
Later template changes do not affect existing Actors' policies: should we make this configurable?
I imagine there are cases where users would like existing actors to pick up a EgressPolicyTemplate change automatically.
| if diff := cmp.Diff(tt.policy.Rules, policy.Rules, protocmp.Transform()); diff != "" { | ||
| t.Errorf("copied rules mismatch (-want +got):\n%s", diff) | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
The tests below this line does not seem to be related to the test table defined above. Please move them to a separate test.
Collaborator
Author
100%, this doesn't change that. The implementation will always be deny by default, this is just a way to add default policy for all actors in a template. |
…changes Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Bowei Du (bowei)
added
kind/feature
This was referenced Sep 29, 2026
Quentin Bisson (QuentinBisson)
added a commit
to giantswarm/substrate
that referenced
this pull request
Sep 29, 2026
… note the rootfs root dependency of kagent-upstream#125 (agent-substrate#1918)
Quentin Bisson (QuentinBisson)
added a commit
to giantswarm/kagent-upstream
that referenced
this pull request
Oct 1, 2026
Quentin Bisson (QuentinBisson)
added a commit
to giantswarm/substrate
that referenced
this pull request
Oct 1, 2026
… root dependency of kagent-upstream#125 (#94) docs(fork): the egress default's upstream exit is agent-substrate#1558; note the rootfs root dependency of kagent-upstream#125 (agent-substrate#1918)
2 tasks done
Quentin Bisson (QuentinBisson)
added a commit
to giantswarm/kagent-upstream
that referenced
this pull request
Oct 5, 2026
…ress policy as its default ActorTemplateForRevision sets default_egress_policy from the revision's egress destinations and credentials, the same allowlist the session workflow creates for each Actor. Substrate copies it onto every Actor it creates from the template, including the golden Actor the template reconciler creates, which no client call could give a policy before it boots: without one the golden boot is denied all egress (403) and a workload that fetches git skills before readyz never gets its snapshot. The workflow's EnsureActorEgressPolicy stays as the idempotent check. The revision digest carries an actorTemplateFormat marker so templates compiled before this change are re-created instead of conflicting. Field names follow agent-substrate/substrate#1558 (ActorTemplate.default_egress_policy, EgressPolicyTemplate.rules). Refs kagent-dev#2604, agent-substrate/substrate#1324
Quentin Bisson (QuentinBisson)
added a commit
to giantswarm/kagent-upstream
that referenced
this pull request
Oct 5, 2026
…ress policy as its default ActorTemplateForRevision sets default_egress_policy from the revision's egress destinations and credentials, the same allowlist the session workflow creates for each Actor. Substrate copies it onto every Actor it creates from the template, including the golden Actor the template reconciler creates, which no client call could give a policy before it boots: without one the golden boot is denied all egress (403) and a workload that fetches git skills before readyz never gets its snapshot. The workflow's EnsureActorEgressPolicy stays as the idempotent check. The revision digest carries an actorTemplateFormat marker so templates compiled before this change are re-created instead of conflicting. Field names follow agent-substrate/substrate#1558 (ActorTemplate.default_egress_policy, EgressPolicyTemplate.rules). Refs kagent-dev#2604, agent-substrate/substrate#1324
Collaborator
Author
|
Closing this in favor of #2159 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow ActorTemplates to define a default egress policy, validated like an EgressPolicy and copied atomically when an Actor is created. Actors without a configured default retain the current behavior; copied policies can be updated or deleted independently.
Validation:
make verifypassed, including rollback and policy lifecycle tests.Fixes #1324