Skip to content

[MNT] Remove REDCOMETs from testing exclusion list #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025
Merged

[MNT] Remove REDCOMETs from testing exclusion list #2630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d2b913
remove excluded estimators
MatthewMiddlehurst Mar 16, 2025
74317d5
redcomets fix
MatthewMiddlehurst Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions aeon/classification/dictionary_based/_redcomets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,7 @@ def _build_univariate_ensemble(self, X, y):
sfa_clfs = []
for sfa in sfa_transforms:
sfa.fit(X_smote, y_smote)
sfa_dics = sfa.transform_words(X_smote)
X_sfa = sfa_dics[:, 0, :]
X_sfa = sfa.transform_words(X_smote)[0]

rf = RandomForestClassifier(
n_estimators=self.n_trees,
Expand Down Expand Up @@ -417,8 +416,7 @@ def _predict_proba_unvivariate(self, X) -> np.ndarray:
pred_mat = np.zeros((X.shape[0], self.n_classes_))

for sfa, (rf, weight) in zip(self.sfa_transforms, self.sfa_clfs):
sfa_dics = sfa.transform_words(X)
X_sfa = sfa_dics[:, 0, :]
X_sfa = sfa.transform_words(X)[0]

rf_pred_mat = rf.predict_proba(X_sfa)

Expand Down
1 change: 0 additions & 1 deletion aeon/testing/testing_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@

# exclude estimators here for short term fixes
EXCLUDE_ESTIMATORS = [
"REDCOMETS",
"HydraTransformer", # returns a pytorch Tensor
]

Expand Down