Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Remove REDCOMETs from testing exclusion list #2630

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

MatthewMiddlehurst
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst commented Mar 16, 2025

Fixes a bug introduced in the last REDCOMETs PR. Between its creation and merge there was an update to SFA fast which broke everything.

@aeon-actions-bot aeon-actions-bot bot added maintenance Continuous integration, unit testing & package distribution testing Testing related issue or pull request labels Mar 16, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#2C2F20}{\textsf{testing}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@MatthewMiddlehurst MatthewMiddlehurst changed the title [MNT] Remove estimators from testing exclusion list [MNT] Remove REDCOMETs from testing exclusion list Mar 16, 2025
@MatthewMiddlehurst MatthewMiddlehurst added the classification Classification package label Mar 16, 2025
@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review March 16, 2025 23:00
Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm !

@MatthewMiddlehurst MatthewMiddlehurst merged commit 93d5079 into main Mar 20, 2025
16 checks passed
@MatthewMiddlehurst MatthewMiddlehurst deleted the mm/excluded-tests branch March 20, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package maintenance Continuous integration, unit testing & package distribution testing Testing related issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants