Update JDK8/J9/Win to use VS2013 instead of VS2010 #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stewart X Addison <sxa@redhat.com>
sxa
added
enhancement
|
Validating at https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/918/OS=Win2012,label=vagrant/ (Result: Tried to activate 2013 and fails as a result of issues with the rebase command which is changed in the upstream OpenJ9 PRs which this has to be merged simultaneously with) |
|
NOTE: Merging of this needs to be co-ordinated with OpenJ9 since it has to be synced with the merging of ibmruntimes/openj9-openjdk-jdk8#449 and eclipse-openj9/openj9#10892 |
🟢 PR TESTER RESULT 🟢✅ All pipelines passed! ✅ |
|
Note to reviewers: Failure on the checks is a macos compiler related error, so unrelated to this PR |
M-Davies
approved these changes
Nov 4, 2020
|
Both upstream changes now merged, so merging this one. |
sxa
added a commit
to sxa/temurin-build
that referenced
this pull request
Nov 18, 2020
…#2227)" This reverts commit 5ba48d9 and reinstates adoptium#2191
karianna
pushed a commit
that referenced
this pull request
Nov 25, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested via #466 (comment)
Signed-off-by: Stewart X Addison sxa@redhat.com