Switch builds to using VS2017 on Windows

[sxa]

Dependent on adoptium/infrastructure#448

[ali-ince]

I have created an upstream PATCH request to enable us to use latest VS2017 with side-by-side minor version MSVC toolsets.

http://mail.openjdk.java.net/pipermail/build-dev/2019-March/025126.html

[ali-ince]

Status update about getting builds to VS2017;

1. All jdk12 and jdk13 builds are already being built on vs2017.
2. All jdk11 builds, except x86 hotspot are built using vs2017. x86 builds are dependent on an upstream patch and once it is applied on jdk11u project, we’ll be switching for that one as well.
3. jdk8u hotspot and openj9 builds are currently being built by vs2013 and vs2010 respectively. We’re working on a patch for hotspot to support vs2017.

[M-Davies]

With the resolution of @ali-ince bug https://bugs.openjdk.java.net/browse/JDK-8220445 and infra issue 448, can this be closed? @sxa

[sxa]

We are not building on VS2017 for all builds, therefore no.

[karianna]

We are not building on VS2017 for all builds, therefore no.

@d3r3kk Is this something our group can look at? Currently we're building using a VS2013 toolchain for Java 8 builds. We'd like to move that to VS2017 - not sure if it will work out of the box or some build script changes would need to be made upstream.

[sxa]

OpenJ9/JDK8 is currently building with VS2010 - they generally track the openjdk supported levels which is why they haven't actively moved up.

I'm not sure where the official source of the build prereqs is but both of these documents list VS2010 (One says 2013 as an option):

• https://hg.openjdk.java.net/jdk8u/jdk8u/raw-file/tip/README-builds.html
• https://cr.openjdk.java.net/~ihse/demo-new-build-readme/common/doc/building.html#windows
• https://github.com/AdoptOpenJDK/openjdk-jdk8u/blob/master/README-builds.html (Perhaps the definitive as it's in the source, but it says 2010)

[andrew-m-leonard]

OpenJDK have fixed the build failure for VS2010/13: https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/097f47e7fe97

[sxa]

@d3r3kk @karianna Any update on this? Are we planning to progress it? OpenJ9 are still using VS2010 on JDK8 and do not plan to move up but we could possible remove our VS2013 requirement if we moved those builds up to VS2017 (assuming it was safe to do so without introducing any backwards compatibility issues!)

[d3r3kk]

Sorry for the late update @sxa - yes, I am slowly working through some solutions to this problem at the moment.

Not least of which is getting the VS2013/17/19 installation to be more reasonable for our build purposes!

[pshipton]

Note that OpenJ9 Java 8 builds are moving to VS2013, as VS2010 is out of support.
eclipse-openj9/openj9#10892
We'd move to VS2015 or VS2017 if possible, but they are currently shown as not working.
https://github.com/ibmruntimes/openj9-openjdk-jdk8/blob/openj9/common/autoconf/toolchain_windows.m4#L61

[pshipton]

Actually, I think Adopt has to be ready to switch to VS2013 before ibmruntimes/openj9-openjdk-jdk8#449 and eclipse-openj9/openj9#10892 are merged, otherwise the builds will fail.

[sxa]

@pshipton Can you confirm if we can update Adopt's builds now to build on VS2013 or do we have to co-ordinate so that all three (my adopt change plus the two you mentioned) go in together? I have a PR ready. (Memo to self: That file really needs a cleanup...)

[pshipton]

@sxa The change needs to be coordinated. The msvcp120.dll is hard coded, the switch won't work without this code change. Once we make the code change, everybody needs to switch. I'm waiting for the all clear from IBM, and then we can deliver the code and make the switch. I think we can target next week.

[karianna]

@d3r3kk - bumping up your food chain

[sxa]

Related: #1026

[sxa]

@karianna @d3r3kk Are we going to progress this? Somebody speak to me please!

[pshipton]

@sxa Did this not already occur? The OpenJ9 changes for jdk8 were delivered long ago. ibmruntimes/openj9-openjdk-jdk8#449
and for Adopt I see #2191

[karianna]

I don't think Hotspot has been updated to build on 2017 for Java 8 yet (needs fixes upstream IIRC).

[pshipton]

Agree with that. If OpenJDK is updated to support building jdk8 with VS2017, then OpenJ9 would change to build with VS2017 as well, instead of VS2013.

[sxa]

I don't think Hotspot has been updated to build on 2017 for Java 8 yet (needs fixes upstream IIRC).

I was assuming from @d3r3kk 's comment that he was investigating JDK8, but since I've not seen any progress or response I'm going to assume it's not being actively worked so will close this once I've determined why https://github.com/AdoptOpenJDK/openjdk-build/blob/fd268fb8de5dddda558714c7d49304c1a075e6c2/build-farm/platform-specific-configurations/windows.sh#L114 doesn't seem to have taken effect (Since JDK11/HS/Win32 still seems to be using VS2013)