Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VS2010_SP1 role to Windows playbook #947

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Conversation

Willsparker
Copy link
Contributor

Fixes: #383
Ref: #553 , #942

Found a way that should download and install VS2010_SP1 from the Windows Playbook. Must have MSVS2010 installed first. I've tested this on a Windows VM that did have MSVS2010 installed prior, but having ran MSVS_2010 and the new VS2010_SP1 tags on the playbook, it showed Microsoft Visual Studio 2010 Version 10.0.40219.1 SP1Rel under help --> about microsoft visual studio, which I believe means SP1 installed correctly.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm if that really does work on all windows versions then I'm good with it ... Curious as to why it couldn't be made to work before though

@sxa
Copy link
Member

sxa commented Oct 3, 2019

(I can't merge until you fix the travis errors though)

@Willsparker
Copy link
Contributor Author

@sxa555 I was googling to try to find a way of downloading VS2010SP1, and I found this atricle : https://old.windowsvalley.com/download-visual-studio-2010-service-pack-1/ which has a link at the bottom ( The one in the playbook role ), that seems to come from Microsoft, but doesn't require signing in to download it. As for the /q problem from before, I'm not sure why it seems to be working, honestly- it may be due to installing a different version VS2010SP1 to the one in #553

@Willsparker
Copy link
Contributor Author

Just FYI, the Travis check were initially failing because there was no "when" in the tasks in the role- I've fixed this by stat checking the setup file has been downloaded, which is probably not the best way of doing it, but I couldn't find any extra files that VS2010SP1 adds to the Visual Studio 10.0 folder in Program Files.

@sxa sxa merged commit dbd7455 into adoptium:master Oct 4, 2019
@karianna karianna added this to the October 2019 milestone Oct 4, 2019
@karianna karianna added the bug label Oct 4, 2019
@Willsparker Willsparker deleted the 383 branch October 7, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add VS2010 SP1 to playbook
3 participants