-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified testScript.sh to allow for Win2012 to build JDK #942
Conversation
Adding [WIP] tag to this PR, as I'm consistently having an error when trying to build a JDK on Windows, in that the build hangs up when attempting to move the workspace- though it also can't find a viable version of Java in a directory that definitely has one, so I'm going to investigate if that is due to an exporting an environment variable issue. |
@Willsparker merge conflicts... |
I've got to the point where the playbook installs the dependencies correctly, and a JDK can now be built on the Windows machine without additional user input- however, when attempting to do this through the script, one of these error messages occur:
Both occur after saving |
Errors have been hit. When attempting to run the |
The new direction I've taken this is to add a role into the playbook that will run the build script on the machine. The previous problems are therefore side-stepped as a different piece of software is communicating with the VM. This contains the tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicks
pbTest: Added Build Role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this as a playbook role is confusing and definitely not the right approach to take. Since I believe ansible and vagrant powershell
are both communicating to the machine over WinRM
there must be an alternate way to make this work.
As per @sxa555 's request, I've removed the role from the playbooks. Instead, the testScript has instead been altered to used the command |
Fixes: #938
With this, all OS' currently supported in
testScript.sh
should be able to test a build.