-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding to Freetype windows role #566
Conversation
JDK8 compile will fail unless freetype is built beforehand, so these changes will build freetype 32bit and 64bit versions inside C:\openjdk\freetype-2.5.3 Signed-off-by: Colton Mills <millscolt3@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I am a little concerned over the fact that the 64bit versions are in fact 32bit. Although building JDK8 or JDK11, it seems not to matter.
How are the 64bit versions actually 32bit? That would probably be an issue. Is this change to support OpenJ9 builds only? I'd probably get @ali-ince and @johnoliver to review this as well if the builds are relying on this... |
Its a requirement for openjdk as I understand it. Microsoft Visual Studio 10.0 is 32bit only. @cwesMills could you test compiling these like you did with the OpenSSL role using Microsoft Visual Studio 12 which has for 32 & 64 bit support? |
Visual Studio 12 gives the same result. When running |
It turns out the |
Okay, I'm good with this solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this was all based on my issue I can't really object, therefore approving too ;-)
Playbook changes for xLinux Java8 machines
JDK8 compile will fail unless freetype is built beforehand, so these changes
will build freetype 32bit and 64bit versions inside C:\openjdk\freetype-2.5.3
Fixes #367
Signed-off-by: Colton Mills millscolt3@gmail.com