Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add building of freetype (32+64 versions) to the Windows playbook #367

Closed
sxa opened this issue May 24, 2018 · 4 comments
Closed

Add building of freetype (32+64 versions) to the Windows playbook #367

sxa opened this issue May 24, 2018 · 4 comments

Comments

@sxa
Copy link
Member

sxa commented May 24, 2018

Current freetype role at https://github.com/AdoptOpenJDK/openjdk-infrastructure/blob/master/ansible/playbooks/AdoptOpenJDK_Windows_Playbook/roles/Freetype/tasks/main.yml seems to download the source but not build it. The built 64-bit version is in C:\openjdk\freetype\{include,lib} on the build machines - unclear of the source. We need a 32-bit version to satisfy adoptium/temurin-build#342, and get both versions into the ansible playbooks for setting up windows machines

@sxa
Copy link
Member Author

sxa commented May 24, 2018

Build on build-softlayer-win2012r2-x64-1 as follows:

msbuild.exe builds\windows\vc2010\freetype.vcxproj /p:PlatformToolset=v100 /p:Configuration="Release Multithreaded" /p:PlatformTarget=x86 /p:ConfigurationType=DynamicLibrary /p:TargetName=freetype /p:OutDir="C:/openjdk/freetype-2.5.3/lib/" /p:IntDir="C:/openjdk/freetype-2,.5.3/obj32/"
msbuild.exe builds\windows\vc2010\freetype.vcxproj /p:PlatformToolset=v100 /p:Configuration="Release Multithreaded" /p:PlatformTarget=x86 /p:ConfigurationType=StaticLibrary /p:TargetName=freetype /p:OutDir="C:/openjdk/freetype-2.5.3/lib/" /p:IntDir="C:/openjdk/freetype-2,.5.3/obj32/"

@karianna karianna changed the title Add building of freettype (32+64 versions) to the Windows playbook Add building of freetype (32+64 versions) to the Windows playbook Jun 5, 2018
@gdams
Copy link
Member

gdams commented Jun 18, 2018

okay so C:\openjdk\freetype\ was prebuilt by myself for the jdk8u builds. The newer builds just take the source and automatically handle the building as part of the job! We'll need to add a custom build of 32 bit though

@sxa sxa added this to the 2018 September A milestone Aug 31, 2018
@sxa sxa modified the milestones: 2018 September B, 2018 October B Oct 1, 2018
@sxa sxa modified the milestones: 2018 October B, 2018 November A Oct 30, 2018
@sxa sxa added this to the 2018 November A milestone Nov 6, 2018
@sxa sxa self-assigned this Nov 6, 2018
@cwesMills
Copy link
Contributor

@sxa555 I've just come across this issue and had to manually build freetype. I'm willing to take over this issue if you'd like.

@sxa
Copy link
Member Author

sxa commented Nov 16, 2018

Thanks @cwesMills (And sorry for the delay in reponding!) Just one of those issues that's been on my backlog for a while so the help is appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants