Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install openssh on Solaris machines #2220

Merged
merged 2 commits into from
Jun 16, 2021
Merged

install openssh on Solaris machines #2220

merged 2 commits into from
Jun 16, 2021

Conversation

gdams
Copy link
Member

@gdams gdams commented Jun 16, 2021

Fixes:

bash-3.2# ssh -T git@github.com
Client and server could not agree on a key exchange algorithm:
  client: diffie-hellman-group-exchange-sha1,diffie-hellman-group14-sha1,diffie-hellman-group1-sha1
  server: curve25519-sha256,curve25519-sha256@libssh.org,ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521,diffie-hellman-group-exchange-sha256

Once installed you need to set GIT_SSH=/opt/csw/bin/ssh

@gdams gdams requested a review from sxa June 16, 2021 10:36
@karianna karianna added this to the June 2021 milestone Jun 16, 2021
karianna
karianna approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams @sxa
Update ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Common/vars…
5129723 
…/Solaris.yml

Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
@gdams
Copy link
Member Author

gdams commented Jun 16, 2021

@sxa updated PTAL

sxa
sxa requested changes Jun 16, 2021
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change to link to the error message, then this sounds good since it doesn't change the system ssh. Are you expecting thinking of setting GIT_SSH on the jenkins agent definition?

@gdams
Copy link
Member Author

gdams commented Jun 16, 2021

@sxa yes I am - see eclipse-cbi/jiro#167

@gdams gdams merged commit 7c7c81f into adoptium:master Jun 16, 2021
@gdams gdams deleted the openssh branch June 16, 2021 14:24
This was referenced Jun 30, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxa sxa sxa approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
ansible
Projects
None yet
Milestone
June 2021
Development

Successfully merging this pull request may close these issues.
3 participants
@gdams @karianna @sxa