pbTests: Update Vagrantfile paths in VPC/vmDestroy

[Willsparker]

Fixes: #2215

VPC currently isn't running cleanly, due to a new issue with vmDestroy.sh. While I can't see that it's related to #2211 , vpc.sh, it suddenly started being an issue after this was merged. Irrespective, vpc.sh needs to be updated to reflect the changes in that PR anyway.

Keeping in Draft until VPC runs are (mostly) green:
https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/1183/

Checklist

• commit message has one of the standard prefixes
• FAQ.md updated if appropriate
• other documentation is changed or added (if applicable)
• playbook changes run through VPC or QPC (if you have access)
• for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

[sxa]

Approving subject to the VPC run passing

[sxa]

Actually, not approving as I've got one change to add some quotes

[karianna]

LGTM - I should have scanned for this last time

[sxa]

@karianna Still not working yet as per the VPC link in the description :-)
@Willsparker are you around today to look at it?
EDIT: Looks like a temporary problem on the nasm download server - re-running at https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/1184/

[sxa]

Better - the build is succeeding on the Linux platforms but tests are failing:

17:32:45 TESTDIR: /home/vagrant/testLocation/openjdk-tests is invalid. Please use --testdir|-t to set valid TESTDIR under aqa-tests. Default value current dir (pwd) is used if not provided.
17:32:46 testJDK.sh: line 15: cd: /home/vagrant/testLocation/openjdk-tests/TKG: No such file or directory

Windows playbook failed on one of the roles so that's unrelated to this I think
Solaris playbook failed with: 14:41:22 fatal: [127.0.0.1]: FAILED! => {"msg": "Timeout (62s) waiting for privilege escalation prompt: sudo: unable to resolve host adoptopenjdkSol10: node name or service name not known\r\r\n"} (Also likely unrelated

[sxa]

Rebased (to include the fix to the test repository location) and retesting at https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/1193/

[sxa]

Looking better so I'm going to take this out of draft and approve/merge. Notes:

• https://github.com/adoptium/infrastructure/pull/2235/files should be canceled as it has a subset of the fixes in here
• Solaris runs are still failing to connect to do the build/test
• Windows runs are still failing due to Ansible request to fix MSVS_2013 broken installation #2178 (Or its dup at Error while installing MSVS_2019 and MSVS2013 on Windows Server 2019 #2231)

[sxa]

Looking better so I'm going to take this out of draft. Notes:

• https://github.com/adoptium/infrastructure/pull/2235/files should be canceled as it has a subset of the fixes in here
• Solaris runs are still failing to connect to do the build/test failing to connect over ssh due to a host key change likely introduced by install openssh on Solaris machines #2220
• Windows runs are still failing due to Ansible request to fix MSVS_2013 broken installation #2178 (Or its dup at Error while installing MSVS_2019 and MSVS2013 on Windows Server 2019 #2231)

Neither of those two failures should prevent this going in, but the Solaris one will need a resolution (Since VPC was broken that one got merged without being tested by VPC)

[sxa]

I'm going to merge this. Please @gdams @karianna can we be careful about making and merging changes going in and make sure things are tested in a selection of environments first. We can't just chuck things into the repo and especially not ignore the side-effects in the future. I'm going to get much tougher on this even if it mandates having a longer review process because we can't allow checks broken for weeks. The right course of action here would have been to merge the revert PR and wait until it could be merged without any problems. Obviously we still have the Solaris issue as mentioned in the previous comment.

Much as we have survived without them in the past and I'd prefer not to have to enforce extra bureacracy, if things like this occur then we will need to start expediting the introduction of some of the processes described in AdoptOpenJDK/TSC#220