consume property in openjdk build.xml #3039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue2918
|
grinder: https://ci.adoptopenjdk.net/job/Grinder/1861/(without checking the USE_TESTENV_PROPERTIES):pass |
llxia
reviewed
Oct 20, 2021
| if (env.SPEC.startsWith('zos')) { | ||
| ADOPTOPENJDK_REPO = ADOPTOPENJDK_REPO.replace("https://github.com/","git@github.com:") | ||
| OPENJ9_REPO = OPENJ9_REPO.replace("https://github.com/","git@github.com:") | ||
| if(!params.USE_TESTENV_PROPERTIES){ |
There was a problem hiding this comment.
Could you rebase the PR? USE_TESTENV_PROPERTIES change is already delivered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #2963
this pr contains the change of pr #2967 since this task depends on that change as it requires the variables in testenv.propertt to be exported as env variables