Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consume property file in system test #2967

Closed
wants to merge 13 commits into from
Closed

Conversation

xius666
Copy link
Contributor

@xius666 xius666 commented Oct 7, 2021

issue #2918

@xius666
Copy link
Contributor Author

xius666 commented Oct 7, 2021

@psaunderualberta
Copy link
Contributor

Did you mean for it to be 'complie'? Shouldn't it be "compile"

@llxia
Copy link
Contributor

llxia commented Oct 26, 2021

This PR contains similar changes as #3083. Is this correct?

@xius666
Copy link
Contributor Author

xius666 commented Oct 26, 2021

This PR contains similar changes as #3083. Is this correct?

yes I think so

@llxia
Copy link
Contributor

llxia commented Oct 26, 2021

Why do we have two PRs with similar changes? And this PR does not have the complete solution. PR #3083 contains the solution that we want.

@xius666
Copy link
Contributor Author

xius666 commented Oct 26, 2021

Why do we have two PRs with similar changes? And this PR does not have the complete solution. PR #3083 contains the solution that we want.

cuz this is an old pr I will close it now

@xius666 xius666 closed this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants