Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get latest nightly build files from given base url #2695

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

OscarQQ
Copy link
Contributor

@OscarQQ OscarQQ commented Jun 30, 2021

related: backlog issue 542
Signed-off-by: Yixin Qian Yixin.Qian@ibm.com

@OscarQQ
Copy link
Contributor Author

OscarQQ commented Jun 30, 2021

run aqa --sdk_resource nightly --build_list functional --target floatSanityTests --platform x86-64_linux --customized_sdk_url https://openj9-artifactory.osuosl.org/artifactory/ci-openj9/Build_JDK11_x86-64_linux_Nightly/

@github-actions
Copy link
Contributor

@OscarQQ

Traceback (most recent call last):
 File "TKG/scripts/testBot/runAqaArgParse.py", line 121, in <module>
 main()
 File "TKG/scripts/testBot/runAqaArgParse.py", line 64, in main
 if config['custom_openj9_repo']:
KeyError: 'custom_openj9_repo'

No builds were started.

@OscarQQ
Copy link
Contributor Author

OscarQQ commented Jun 30, 2021

run aqa --sdk_resource nightly --build_list functional --target testSCCMLTests2 --platform x86-64_windows --customized_sdk_url https://openj9-artifactory.osuosl.org/artifactory/ci-openj9/Build_JDK11_x86-64_linux_Nightly/

@github-actions
Copy link
Contributor

@OscarQQ

Traceback (most recent call last):
 File "TKG/scripts/testBot/runAqaArgParse.py", line 121, in <module>
 main()
 File "TKG/scripts/testBot/runAqaArgParse.py", line 64, in main
 if config['custom_openj9_repo']:
KeyError: 'custom_openj9_repo'

No builds were started.

@llxia
Copy link
Contributor

llxia commented Jun 30, 2021

Regarding run aqa failure (#2695 (comment)), issue opened at #2697

@llxia
Copy link
Contributor

llxia commented Jun 30, 2021

Thanks @OscarQQ . With this PR, we will allow users to provide a base artifactory URL (URL before the build number). Our test script will try to figure out the latest build number and it will try to download all tar (including SDK, test image, debug image, etc).

Use case in Grinder:
SDK_RESOURCE=nightly
CUSTOMIZED_SDK_URL=https://openj9-artifactory.osuosl.org/artifactory/ci-openj9/Build_JDK11_x86-64_linux_Nightly

@llxia
Copy link
Contributor

llxia commented Jun 30, 2021

@OscarQQ users may or may not have / at the end of the URL, please make sure we cover both cases. That is, https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1001/console should work. Thanks

@OscarQQ OscarQQ force-pushed the feature2 branch 14 times, most recently from 2832742 to 7a0149f Compare July 5, 2021 04:58
get.sh Outdated Show resolved Hide resolved
@OscarQQ
Copy link
Contributor Author

OscarQQ commented Jul 5, 2021

Grinder/16835. aix
Grinder/16836 x86-64_windows
Grinder/16837. zos
Grinder/16838. x86-64_linux
Grinder/16839. ppc64le
Grinder/16840. s390x
Grinder/16841. x86-64_mac

get.sh Outdated Show resolved Hide resolved
@OscarQQ OscarQQ force-pushed the feature2 branch 2 times, most recently from 4e429fa to 039ea4b Compare July 6, 2021 03:32
@OscarQQ OscarQQ force-pushed the feature2 branch 14 times, most recently from 76f00bc to 6b4a624 Compare July 6, 2021 18:52
related: backlog issue 542
Signed-off-by: Yixin Qian <Yixin.Qian@ibm.com>
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot @OscarQQ
During the testing, we noticed that the latest build may not contain SDK (due to SDK build failure). We will add further enhancement in future PR - try old builds if the latest build does not contain SDK.

@llxia llxia requested a review from smlambert July 7, 2021 17:33
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this enhancement @OscarQQ ! LGTM

@smlambert smlambert merged commit c35812b into adoptium:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants