Merged
Conversation
…ng with edit pdf (#575) Fetch target campaign for mboxid 'acom_unity_'< product >'_'< verb >'_region' Using alloy sdk(_satellite.track) for fetch call Added Unit Test Target code is present in a separate file experiment-provider.js for optimisation We should not send the variantId in payload if the variant fetch fails. BE will provide the default URL in that case for pdf-editor Added warning analytics to capture the failure during fetching experiment data Resolves: [MWPW-173563](https://jira.corp.adobe.com/browse/MWPW-173563) Test URLs: Before: https://stage--dc--adobecom.aem.live/acrobat/online/pdf-editor After: https://stage--dc--adobecom.aem.live/acrobat/online/pdf-editor?unitylibs=editPdf-ab --------- Co-authored-by: rohitsahu <sahurohit9@gmail.com> Co-authored-by: Rohit Sahu <rosahu@adobe.com> Co-authored-by: Arushi Gupta <arugupta@arushis-mbp.corp.adobe.com> Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local> Co-authored-by: Vipul Gupta <vipugpta@gmail.com>
PS automation tests https://jira.corp.adobe.com/browse/MWPW-178449 https://jira.corp.adobe.com/browse/MWPW-178450 https://jira.corp.adobe.com/browse/MWPW-178451 **Test URLs:** https://main--cc--adobecom.hlx.live/drafts/nala/unity/remove-background --------- Co-authored-by: Santoshkumar Nateekar <santoshkumar.sn@gmail.com>
<!-- Before submitting, please review all open PRs. --> Update the look and feel of the FF prompt bar to better align with updates going out from the product team. * Style updates to prompt bar. * Add support for light/dark theme * Do not display verb dropdown menu if only one verb is authored * Remove icons from selected verb dropdown when multiple verbs are authored. Resolves: [MWPW-179765](https://jira.corp.adobe.com/browse/MWPW-179765) **Test URLs:** - Before: https://main--cc--adobecom.aem.live/drafts/rclayton/firefly/text-to-image?martech=off - After: https://main--cc--adobecom.aem.live/drafts/rclayton/firefly/text-to-image?unitylibs=ff-reskin&martech=off Additional testing URLs: - **Light theme** - https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/text-to-image-light-dropdown?unitylibs=ff-reskin - **Dark no dropdown menu** - https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/reskin?unitylibs=ff-reskin - **Light no dropdown men**u - https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/text-to-image-light?unitylibs=ff-reskin --------- Co-authored-by: Ryan Clayton <rclayton@adobe.com>
* Add support for lightroom workflow * Add common util file for file chunking * Unit tests * Nala Tests Resolves: [MWPW-180571](https://jira.corp.adobe.com/browse/MWPW-180571) **Test URLs:** - Before: https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=stage&martech=off - After: https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=MWPW-180571&martech=off **Testing Notes:** **Lightroom testing** 1. Test with various size of jpeg files and make when the file is greater than 10 MB file is uploaded in chunks 2. File type supported is jpeg/jpg 3. Max size supported is 40 MB 4. If you get 403 when landing on the product page please open this url in browser in another tab https://f0.lightroom.adobe.com/tkt/#magic=split-rocker 5. Clear your cookies and test in normal window and not in incognito. We are seeing some issue on product page when testing incognito. 6. This is going to be a desktop only feature. Authors will most likely achieve it by using MEP **Photoshop Testing:** 1. As this PR is touching the code for workflow-upload, please do a regression PS workflow too Authoring Documentation: https://wiki.corp.adobe.com/display/adobedotcom/CC+Upload+Configurator+for+Lightroom
This reverts commit 5a21c31.
Adds update to style.css to allow the hero-block to have a different theme (light/dark) than the unity block. [Related Slack conversation](https://adobedotcom.slack.com/archives/C08MX138AK1/p1760110400687269) Resolves: [MWPW-179765](https://jira.corp.adobe.com/browse/MWPW-179765) **Test URLs:** - Before: https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/golive/firefly?unitylibs=stage&martech=off - After: https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/golive/firefly?unitylibs=ff-adjust-theme&martech=off <img width="1481" height="688" alt="image" src="https://github.com/user-attachments/assets/33e265da-95c5-46c2-a7b4-c95f10fc4df5" />
<!-- Before submitting, please review all open PRs. --> This PR revers updates made in #584 This is a solve for MAX to reduce authoring efforts adopting new prompt bar designs. * Reverse prompt bar light/dark theme colors. Resolves: [MWPW-179765](https://jira.corp.adobe.com/browse/MWPW-179765) **Test URLs:** - Before: https://main--cc--adobecom.aem.page/de/products/firefly?stage&martech=off - After: https://main--cc--adobecom.aem.page/de/products/firefly?unitylibs=ff-reskin-reverse&martech=off <img width="1475" height="808" alt="image" src="https://github.com/user-attachments/assets/6e0326a5-a105-4a20-9dd7-591295a33846" /> Co-authored-by: Ryan Clayton <rclayton@adobe.com>
<!-- Before submitting, please review all open PRs. --> * Updates position of error toast after reskin. Resolves: [MWPW-182082](https://jira.corp.adobe.com/browse/MWPW-182082) **Test URLs:** - Before: https://main--cc--adobecom.aem.page/products/firefly?unitylibs=stage&martech=off - After: https://main--cc--adobecom.aem.page/products/firefly?unitylibs=ff-reskin-alert&martech=off **Sans verb dropdown menu** - Before: https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/text-to-image-light?unitylibs=stage&martech=off - After: https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/text-to-image-light?unitylibs=ff-reskin-alert&martech=off **Templage page** - Before: https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/golive/firefly?unitylibs=stage&martech=off - After: https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/golive/firefly?unitylibs=ff-reskin-alert&martech=off **Testing notes:** There are two displays of the prompt bar now. 1. One with a dropdown menu that makes the prompt bar taller 2. One without the dropdown menu where the prompt bar is shorter. Along with some authoring variations of the hero marquee. These differences create some minor spacing differences as to where the error toast displays. Nothing major, but noting there is some position differenced based on the above details <img width="1466" height="1179" alt="image" src="https://github.com/user-attachments/assets/336dbe9c-32cc-4665-b5b4-7a66e60ba88e" /> <img width="747" height="377" alt="image" src="https://github.com/user-attachments/assets/50d87840-8c67-49de-9cbc-a98210ed0327" /> Co-authored-by: Ryan Clayton <rclayton@adobe.com>
arugupta1992
requested review from
Ruchika4,
rgclayton,
sanjayms01 and
vipu0303
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
vipu0303
approved these changes
Oct 15, 2025
sanjayms01
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test URLs:
Before: https://stage--dc--adobecom.aem.page/acrobat/online/pdf-to-png?unitylibs=main
After: https://stage--dc--adobecom.aem.page/acrobat/online/pdf-to-png?unitylibs=release42