Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
sanjayms01
approved these changes
Oct 14, 2025
Ruchika4
approved these changes
Oct 14, 2025
Collaborator
|
issue tested in branch and now the error toast shows with correct alignment. |
arugupta1992
pushed a commit
that referenced
this pull request
Oct 15, 2025
<!-- Before submitting, please review all open PRs. --> * Updates position of error toast after reskin. Resolves: [MWPW-182082](https://jira.corp.adobe.com/browse/MWPW-182082) **Test URLs:** - Before: https://main--cc--adobecom.aem.page/products/firefly?unitylibs=stage&martech=off - After: https://main--cc--adobecom.aem.page/products/firefly?unitylibs=ff-reskin-alert&martech=off **Sans verb dropdown menu** - Before: https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/text-to-image-light?unitylibs=stage&martech=off - After: https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/text-to-image-light?unitylibs=ff-reskin-alert&martech=off **Templage page** - Before: https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/golive/firefly?unitylibs=stage&martech=off - After: https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/golive/firefly?unitylibs=ff-reskin-alert&martech=off **Testing notes:** There are two displays of the prompt bar now. 1. One with a dropdown menu that makes the prompt bar taller 2. One without the dropdown menu where the prompt bar is shorter. Along with some authoring variations of the hero marquee. These differences create some minor spacing differences as to where the error toast displays. Nothing major, but noting there is some position differenced based on the above details <img width="1466" height="1179" alt="image" src="https://github.com/user-attachments/assets/336dbe9c-32cc-4665-b5b4-7a66e60ba88e" /> <img width="747" height="377" alt="image" src="https://github.com/user-attachments/assets/50d87840-8c67-49de-9cbc-a98210ed0327" /> Co-authored-by: Ryan Clayton <rclayton@adobe.com>
This was referenced Oct 15, 2025
Closed
Merged
sanjayms01
added a commit
that referenced
this pull request
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-182082
Test URLs:
Sans verb dropdown menu
Templage page
Testing notes:
There are two displays of the prompt bar now.
Along with some authoring variations of the hero marquee.
These differences create some minor spacing differences as to where the error toast displays. Nothing major, but noting there is some position differenced based on the above details