Skip to content

fix: ramp slider (#829) #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2020
Merged

fix: ramp slider (#829) #923

merged 2 commits into from
Sep 22, 2020

Conversation

bernhard-adobe
Copy link
Contributor

@bernhard-adobe bernhard-adobe commented Sep 17, 2020

Adding back ramp-slider and removing color-slider.

Description

Addresses issue #829

  • added back ramp-slider
  • removed color-slider from slider page that is now it's own component under /docs/colorslider.html

How and where has this been tested?

URL: http://localhost:3000/docs/slider.html
Chrome Version 85.0.4183.102 (Official Build) (64-bit) on MacOS

Screenshots

Screen Shot 2020-09-22 at 13 16 22

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@bernhard-adobe bernhard-adobe mentioned this pull request Sep 17, 2020
4 tasks
@bernhard-adobe bernhard-adobe changed the base branch from main to spectrum-tokens-17 September 17, 2020 19:40
Copy link
Member

@lazd lazd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message needs to include:

BREAKING CHANGE: Slider color variant removed, used Color Slider component

Also need migration guide.

@bernhard-adobe
Copy link
Contributor Author

Good points @lazd .
I added a migration guide. Unfortunately your suggested commit message is not working because of the commit rules with uppercases:

$ g commit -m "BREAKING CHANGE: Slider color variant removed, used Color Slider component"
husky > commit-msg (node v12.16.2)
⧗   input: BREAKING CHANGE: Slider color variant removed, used Color Slider component
✖   header must not be longer than 72 characters, current length is 74 [header-max-length]
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 3 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

I used instead g commit -m "fix: breaking change: slider color variant moved to color slider. (#850)"
I also added the breaking-change label.

@bernhard-adobe bernhard-adobe added breaking change Results in a breaking API change Component: Color Slider labels Sep 21, 2020
@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@GarthDB
Copy link
Member

GarthDB commented Sep 21, 2020

The disabled color seems to have changed for ramp slider. Is that a result of the tokens changing?

BREAKING CHANGE: Color slider is now a separate component
@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@GarthDB GarthDB merged commit c539411 into spectrum-tokens-17 Sep 22, 2020
@GarthDB GarthDB deleted the SDS-850--slider branch September 22, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Results in a breaking API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants