Skip to content

Commit ba0622b

Browse files
fix: breaking change: slider color variant moved to color slider. (#850)
1 parent 9184837 commit ba0622b

File tree

3 files changed

+52
-42
lines changed

3 files changed

+52
-42
lines changed

components/slider/index.css

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ governing permissions and limitations under the License.
4747
--spectrum-slider-color-track-margin-left: 0;
4848
--spectrum-slider-color-track-margin-right: 0;
4949
--spectrum-slider-color-handle-top: 50%;
50+
51+
--spectrum-slider-ramp-margin-top: 0;
5052

5153
--spectrum-slider-range-track-reset: 0;
5254
--spectrum-label-text-size: var(--spectrum-global-dimension-font-size-75);
@@ -176,6 +178,24 @@ governing permissions and limitations under the License.
176178
}
177179
}
178180

181+
.spectrum-Slider-ramp {
182+
margin-block-start: var(--spectrum-slider-ramp-margin-top);
183+
block-size: var(--spectrum-slider-ramp-track-height);
184+
185+
position: absolute;
186+
inset-inline-start: var(--spectrum-slider-track-margin-offset);
187+
inset-inline-end: var(--spectrum-slider-track-margin-offset);
188+
inset-block-start: calc(var(--spectrum-slider-ramp-track-height) / 2);
189+
190+
svg {
191+
inline-size: 100%;
192+
block-size: 100%;
193+
194+
/* Flip the ramp automatically for RTL */
195+
transform: logical rotate(0deg);
196+
}
197+
}
198+
179199
.spectrum-Slider-handle {
180200
position: absolute;
181201
inset-inline-start: 0;
@@ -368,6 +388,7 @@ governing permissions and limitations under the License.
368388
}
369389
}
370390

391+
371392
.spectrum-Slider {
372393
&.is-disabled {
373394
cursor: default;
@@ -379,6 +400,7 @@ governing permissions and limitations under the License.
379400
}
380401
}
381402

403+
382404
.u-isGrabbing {
383405
cursor: ns-resize;
384406
cursor: -webkit-grabbing;

components/slider/metadata/slider.yml

Lines changed: 7 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
name: Slider
22
SpectrumSiteSlug: https://spectrum.adobe.com/page/slider/
3+
sections:
4+
- name: Migration Guide
5+
description: |
6+
### Color Slider moved out of Sliders into it's own component
7+
Color Slider moved to [Color slider](colorslider.html).
8+
Replace class names starting with `.spectrum-Slider` to `.spectrum-ColorSlider`.
39
examples:
410
- id: slider
511
name: Standard
@@ -352,45 +358,4 @@ examples:
352358
</div>
353359
</div>
354360
</div>
355-
- id: slider-color
356-
name: Color
357-
status: Deprecated
358-
details: A new color slider is forthcoming.
359-
description: Spectrum Color slider
360-
markup: |
361-
<div class="spectrum-Slider spectrum-Slider--color">
362-
<div class="spectrum-Slider-labelContainer">
363-
<label class="spectrum-Slider-label" id="spectrum-Slider--color-label-0" for="spectrum-Slider--color-input-0">Color</label>
364-
<div class="spectrum-Slider-value" role="textbox" aria-readonly="true" aria-labelledby="spectrum-Slider--color-label-0">#2680eb</div>
365-
</div>
366-
<div class="spectrum-Slider-controls">
367-
<div class="spectrum-Slider-track" style="background: linear-gradient(to right, rgb(38, 128, 235), rgb(9, 90, 186))"></div>
368-
<div class="spectrum-Slider-handle" style="left: 40%;">
369-
<input type="range" class="spectrum-Slider-input" value="14" aria-valuetext="#2680eb" step="2" min="10" max="20" id="spectrum-Slider--color-input-0">
370-
</div>
371-
</div>
372-
</div>
373-
<div class="spectrum-Slider spectrum-Slider--color">
374-
<div class="spectrum-Slider-labelContainer">
375-
<label class="spectrum-Slider-label" id="spectrum-Slider--color-label-1" for="spectrum-Slider--color-input-1">Color (showing alpha)</label>
376-
<div class="spectrum-Slider-value" role="textbox" aria-readonly="true" aria-labelledby="spectrum-Slider--color-label-1">#2680eb</div>
377-
</div>
378-
<div class="spectrum-Slider-controls">
379-
<div class="spectrum-Slider-track" style="background: linear-gradient(to right, rgba(38, 128, 235, .5), rgb(9, 90, 186))"></div>
380-
<div class="spectrum-Slider-handle" style="left: 40%;">
381-
<input type="range" class="spectrum-Slider-input" value="14" aria-valuetext="#2680eb" step="2" min="10" max="20" id="spectrum-Slider--color-input-1">
382-
</div>
383-
</div>
384-
</div>
385-
<div class="spectrum-Slider spectrum-Slider--color is-disabled">
386-
<div class="spectrum-Slider-labelContainer">
387-
<label class="spectrum-Slider-label" id="spectrum-Slider--color-label-2" for="spectrum-Slider--color-input-2">Color</label>
388-
<div class="spectrum-Slider-value" role="textbox" aria-readonly="true" aria-labelledby="spectrum-Slider--color-label-2">#2680eb</div>
389-
</div>
390-
<div class="spectrum-Slider-controls">
391-
<div class="spectrum-Slider-track" style="background: linear-gradient(to right, rgba(38, 128, 235, .5), rgb(9, 90, 186))"></div>
392-
<div class="spectrum-Slider-handle" style="left: 40%;">
393-
<input type="range" class="spectrum-Slider-input" value="14" aria-valuetext="#2680eb" step="2" min="10" max="20" disabled id="spectrum-Slider--color-input-2">
394-
</div>
395-
</div>
396-
</div>
361+

components/slider/skin.css

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,12 @@ governing permissions and limitations under the License.
5252
}
5353
}
5454

55+
.spectrum-Slider-ramp {
56+
path {
57+
fill: var(--spectrum-slider-track-color);
58+
}
59+
}
60+
5561
.spectrum-Slider-handle {
5662
border-color: var(--spectrum-slider-handle-border-color);
5763
background: var(--spectrum-slider-handle-background-color);
@@ -75,6 +81,14 @@ governing permissions and limitations under the License.
7581
}
7682
}
7783

84+
85+
.spectrum-Slider--ramp {
86+
.spectrum-Slider-handle {
87+
/* We can't draw this one correctly without this hack : ( */
88+
box-shadow: 0 0 0 4px var(--spectrum-alias-background-color-default);
89+
}
90+
}
91+
7892
.spectrum-Slider-input {
7993
background: transparent;
8094
}
@@ -85,6 +99,7 @@ governing permissions and limitations under the License.
8599
}
86100
}
87101

102+
88103
.spectrum-Slider-handle {
89104
&.is-dragged {
90105
border-color: var(--spectrum-slider-handle-border-color-down);
@@ -102,6 +117,7 @@ governing permissions and limitations under the License.
102117
}
103118
}
104119

120+
105121
.spectrum-Slider {
106122
&.is-disabled {
107123
.spectrum-Slider-labelContainer {
@@ -136,6 +152,13 @@ governing permissions and limitations under the License.
136152
}
137153
}
138154

155+
.spectrum-Slider-ramp {
156+
path {
157+
fill: var(--spectrum-slider-ramp-track-color-disabled);
158+
}
159+
}
160+
161+
139162
&.spectrum-Slider--range {
140163
.spectrum-Slider-track {
141164
&:not(:first-of-type):not(:last-of-type) {

0 commit comments

Comments
 (0)