fix: Checkbox and Radio margins, docs, and typography #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
VRT successfully! 🎊 |
|
VRT successfully! 🎊 |
|
VRT successfully! 🎊 |
|
VRT successfully! 🎊 |
|
VRT successfully! 🎊 |
lazd
force-pushed
the
checkyradiofieldy
branch
from
6cfb186 to
7e3982c
Compare
BREAKING CHANGE: Checkbox and Radio no longer have margin on their own, must use FieldGroup
BREAKING CHANGE: The spectrum-FieldGroup--horizontal is now required for horizontal field groups
lazd
force-pushed
the
checkyradiofieldy
branch
from
7e3982c to
3da1518
Compare
|
VRT successfully! 🎊 |
|
VRT successfully, result is here Not sure why adobe-spectrum-bot is unable to post the message here. |
|
LGTM |
jianliao
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes up Checkbox and Radio's margins, docs, and typography.
It addresses #243 by setting text styles on the label of the Checkbox/Radio explicitly, instead of relying on inheritance.
It addresses #124 by removing margin from Checkbox/Radio, instead making FieldGroup required to add the margin. THIS IS A BREAKING CHANGE.
#707 is addressed by adding columns for default, invalid, and disabled for Checkbox/Radio, and moving the wrapping example to its own section.
#484 is fixed as a dep was missing from Form.
How and where has this been tested?
Screenshots
To-do list