fix(textfield): update border and background color #3575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8d61bd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
File metricsSummaryTotal size: 2.25 MB*
textfield
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
|
🚀 Deployed on https://pr-3575--spectrum-css.netlify.app |
castastrophe
added
size-2 S
|
@TarunAdobe Can you please update the branch with the base branch and write out a few validation test cases in the pull request template for us to confirm the updates? |
|
@TarunAdobe Can you please write out your validation steps for your PRs? See this as an example: #3547 |
TarunAdobe
added
run_vrt
TarunAdobe
force-pushed
the
ttomar/swc-576
branch
from
172779e to
746cb62
Compare
rise-erpelding
approved these changes
Feb 27, 2025
castastrophe
approved these changes
Feb 27, 2025
castastrophe
force-pushed
the
ttomar/swc-576
branch
2 times, most recently
from
9de29d5 to
1612506
Compare
pfulton
force-pushed
the
ttomar/swc-576
branch
from
1612506 to
8d61bd6
Compare
Merged
castastrophe
added a commit
that referenced
this pull request
Mar 4, 2025
* fix(textfield): update border and background color * fix(swatch): adjust disabled icon color across themes (#3547) * fix(textfield): update border color on keyfocus in s2 --------- Co-authored-by: [ Cassondra ] <castastrophe@users.noreply.github.com> Co-authored-by: rise-erpelding <54716846+rise-erpelding@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updated border color for key-focus state of textfield in spectrum-two theme.
swc-576
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Include steps for the PR reviewer that explain how they should test your PR. Example test outline:
tabto focus over the textfield and validate the border color isgray-800as from the design specsRegression testing
Validate:
Screenshots
To-do list