Skip to content

Commit 8d61bd6

Browse files
TarunAdobepfulton
authored andcommitted
fix(textfield): update border color on keyfocus in s2
1 parent b3eb5b2 commit 8d61bd6

File tree

5 files changed

+18
-16
lines changed

5 files changed

+18
-16
lines changed

.changeset/strong-falcons-switch.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
"@spectrum-css/textfield": patch
33
---
44

5-
updated border color for keyfocus and focus state and updated background and border color for default disabled state in s2
5+
updated border color on keyboard focus state for textfield in spectrum-two theme

.storybook/CHANGELOG.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010

1111
### Patch Changes
1212

13-
- [#3528](https://github.com/adobe/spectrum-css/pull/3528) [`bee70fb`](https://github.com/adobe/spectrum-css/commit/bee70fbab5f12b49ce2611366b614c75277e0aa9) Thanks [@castastrophe](https://github.com/castastrophe)!
13+
- [#3528](https://github.com/adobe/spectrum-css/pull/3528) [`bee70fb`](https://github.com/adobe/spectrum-css/commit/bee70fbab5f12b49ce2611366b614c75277e0aa9) Thanks [@castastrophe](https://github.com/castastrophe)!
1414
- Update fetchToken to use the exported JSON from @spectrum-css/tokens instead of @adobe/spectrum-tokens
1515

16-
- [#3541](https://github.com/adobe/spectrum-css/pull/3541) [`1a3245c`](https://github.com/adobe/spectrum-css/commit/1a3245c3a660bc52ed260f18b6cceab5ee81541d) Thanks [@castastrophe](https://github.com/castastrophe)!
16+
- [#3541](https://github.com/adobe/spectrum-css/pull/3541) [`1a3245c`](https://github.com/adobe/spectrum-css/commit/1a3245c3a660bc52ed260f18b6cceab5ee81541d) Thanks [@castastrophe](https://github.com/castastrophe)!
1717
- Dependency alignment across the project.
1818

1919
Set component peerDependencies as optional to reduce console warnings on downstream projects.
@@ -33,12 +33,10 @@
3333

3434
### Major Changes
3535

36-
- [#2786](https://github.com/adobe/spectrum-css/pull/2786) [`6c19fcf`](https://github.com/adobe/spectrum-css/commit/6c19fcf3f0eda76987f338981ae20f9999febce6) Thanks [@pfulton](https://github.com/pfulton)!
36+
- [#2786](https://github.com/adobe/spectrum-css/pull/2786) [`6c19fcf`](https://github.com/adobe/spectrum-css/commit/6c19fcf3f0eda76987f338981ae20f9999febce6) Thanks [@pfulton](https://github.com/pfulton)!
3737

3838
#### Breaking change
3939

40-
This update removes the previously deprecated component documentation for **cyclebutton**, **quickaction**, **searchwithin**, and **splitbutton**.
41-
4240
This update removes the previously deprecated component documentation for **cyclebutton**, **quickaction**, **searchwithin**, and **splitbutton**.
4341

4442
To support the Spectrum 2 (S2) Foundations release, Storybook has been updated to toggle token packages to connect the following labels with their appropriate data sources:
@@ -49,7 +47,9 @@ To support the Spectrum 2 (S2) Foundations release, Storybook has been updated t
4947

5048
This release also includes:
5149

52-
#### Patch Changes
50+
- New migration documentation for S1 -> S2 updates
51+
- Fix for the duplicate line numbers in the code preview plugin
52+
- Updated styles to integrate Spectrum styling into the Storybook UI
5353

5454
#### Patch Changes
5555

@@ -61,7 +61,7 @@ This release also includes:
6161

6262
### Patch Changes
6363

64-
- [#3522](https://github.com/adobe/spectrum-css/pull/3522) [`7a47c22`](https://github.com/adobe/spectrum-css/commit/7a47c2266b6d0e8c99061fe85cba8d52684bae39) Thanks [@castastrophe](https://github.com/castastrophe)!
64+
- [#3522](https://github.com/adobe/spectrum-css/pull/3522) [`7a47c22`](https://github.com/adobe/spectrum-css/commit/7a47c2266b6d0e8c99061fe85cba8d52684bae39) Thanks [@castastrophe](https://github.com/castastrophe)!
6565
- Minor storybook updates and fixes including some whitespace changes.
6666

6767
A bug was fixed with the HTML code preview that was displaying duplicate line numbers.
@@ -86,7 +86,7 @@ This release also includes:
8686

8787
### Major Changes
8888

89-
- [#3458](https://github.com/adobe/spectrum-css/pull/3458) [`e1b7102`](https://github.com/adobe/spectrum-css/commit/e1b71027f92ce18feb3a63c100d2b4871fc73b9f) Thanks [@castastrophe](https://github.com/castastrophe)!
89+
- [#3458](https://github.com/adobe/spectrum-css/pull/3458) [`e1b7102`](https://github.com/adobe/spectrum-css/commit/e1b71027f92ce18feb3a63c100d2b4871fc73b9f) Thanks [@castastrophe](https://github.com/castastrophe)!
9090
- Update the Chromatic add-on to the currently maintained package:
9191

9292
- from "@chromaui/addon-visual-tests": "^1.0.0"
@@ -100,14 +100,14 @@ This release also includes:
100100

101101
### Patch Changes
102102

103-
- [#3440](https://github.com/adobe/spectrum-css/pull/3440) [`6808c85`](https://github.com/adobe/spectrum-css/commit/6808c85295d472286c0a52e28d2279b2b5a16f92) Thanks [@castastrophe](https://github.com/castastrophe)!
103+
- [#3440](https://github.com/adobe/spectrum-css/pull/3440) [`6808c85`](https://github.com/adobe/spectrum-css/commit/6808c85295d472286c0a52e28d2279b2b5a16f92) Thanks [@castastrophe](https://github.com/castastrophe)!
104104
- Fix an issue where "show code" was blocking loading in Storybook docs pages [CSS-1070]
105105

106106
## 10.12.0
107107

108108
### Minor Changes
109109

110-
- [#3477](https://github.com/adobe/spectrum-css/pull/3477) [`d52c701`](https://github.com/adobe/spectrum-css/commit/d52c70196bf2d17433c239313a82f00f75d77e79) Thanks [@castastrophe](https://github.com/castastrophe)!
110+
- [#3477](https://github.com/adobe/spectrum-css/pull/3477) [`d52c701`](https://github.com/adobe/spectrum-css/commit/d52c70196bf2d17433c239313a82f00f75d77e79) Thanks [@castastrophe](https://github.com/castastrophe)!
111111
- Update Storybook to leverage the new CSS bundled assets.
112112

113113
### Patch Changes

components/textfield/dist/metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,11 +292,11 @@
292292
"--spectrum-font-size-200",
293293
"--spectrum-font-size-300",
294294
"--spectrum-font-size-75",
295-
"--spectrum-gray-200",
296295
"--spectrum-gray-25",
297296
"--spectrum-gray-300",
298297
"--spectrum-gray-500",
299298
"--spectrum-gray-600",
299+
"--spectrum-gray-800",
300300
"--spectrum-gray-900",
301301
"--spectrum-help-text-to-component",
302302
"--spectrum-negative-border-color-default",

components/textfield/themes/spectrum-two.css

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@
1414
@container style(--system: spectrum) {
1515
.spectrum-Textfield {
1616
--spectrum-textfield-background-color: var(--spectrum-gray-25);
17-
--spectrum-textfield-background-color-disabled: var(--spectrum-gray-200);
17+
--spectrum-textfield-background-color-disabled: var(--spectrum-gray-25);
1818

1919
--spectrum-textfield-border-color: var(--spectrum-gray-500);
2020
--spectrum-textfield-border-color-hover: var(--spectrum-gray-600);
21-
--spectrum-textfield-border-color-focus: var(--spectrum-gray-500);
21+
--spectrum-textfield-border-color-focus: var(--spectrum-gray-800);
2222
--spectrum-textfield-border-color-focus-hover: var(--spectrum-gray-900);
23-
--spectrum-textfield-border-color-keyboard-focus: var(--spectrum-gray-900);
24-
--spectrum-textfield-border-color-disabled: transparent;
23+
--spectrum-textfield-border-color-keyboard-focus: var(--spectrum-gray-800);
24+
--spectrum-textfield-border-color-disabled: var(--spectrum-gray-300);
2525

2626
--spectrum-textfield-border-width: var(--spectrum-border-width-100);
2727

components/textfield/themes/spectrum.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222

2323
--spectrum-textfield-border-color-disabled: var(--spectrum-gray-200);
2424

25+
--spectrum-textfield-border-color-keyboard-focus: var(--spectrum-gray-900);
26+
2527
--spectrum-textfield-icon-spacing-block-invalid: var(--spectrum-field-top-to-alert-icon-medium);
2628

2729
&.spectrum-Textfield--sizeS {

0 commit comments

Comments
 (0)