Skip to content

refactor(assetcard)!: token migration #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Nov 2, 2023
Merged

refactor(assetcard)!: token migration #2229

merged 19 commits into from
Nov 2, 2023

Conversation

jenndiaz
Copy link
Contributor

@jenndiaz jenndiaz commented Oct 26, 2023 •
edited by castastrophe
Loading

Description

Migrates AssetCard

  • Addresses empty checkbox label in docs site and storybook
  • adds WHCM values for selectionIndicatorOrder
  • adds alt text to the card image
  • Replace visibility with display

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

  1. Open the docs site for the asset card component:
  • No visual differences between production and this branch
  • when emulating WHCM, highlight color border should appear on hover for the card border and the checkbox

Regression testing

Validate:

  1. A legacy documentation page (such as accordion), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive
  1. A migrated documentation page (such as action group), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive

Screenshots

To-do list

  • I have read the contribution guidelines.

  • I have updated relevant storybook stories and templates.

  • I have tested these changes in Windows High Contrast mode.

  • If my change impacts other components, I have tested to make sure they don't break.

  • If my change impacts documentation, I have updated the documentation accordingly.

  • ✨ This pull request is ready to merge. ✨

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023 •
edited
Loading

🚀 Deployed on https://pr-2229--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 26, 2023 12:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 26, 2023 13:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 27, 2023 19:29 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 27, 2023 22:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 30, 2023 23:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 31, 2023 18:06 Inactive
@jenndiaz jenndiaz force-pushed the jenndiaz/css-519-asset-card-migration branch from cb57cfa to 18238db Compare October 31, 2023 19:10
@github-actions github-actions bot temporarily deployed to pull request October 31, 2023 19:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 31, 2023 20:54 Inactive
@jenndiaz jenndiaz added the run_vrt For use on PRs looking to kick off VRT label Oct 31, 2023
@jenndiaz jenndiaz marked this pull request as ready for review October 31, 2023 23:05
@jenndiaz jenndiaz removed the run_vrt For use on PRs looking to kick off VRT label Oct 31, 2023
@jenndiaz jenndiaz requested review from pfulton, jawinn and mdt2 October 31, 2023 23:13
jenndiaz
jenndiaz commented Oct 31, 2023
View reviewed changes
@jenndiaz jenndiaz mentioned this pull request Nov 1, 2023
Closed
12 tasks
@jenndiaz jenndiaz requested a review from castastrophe November 1, 2023 15:57
@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label Nov 1, 2023
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Nov 1, 2023
castastrophe
castastrophe requested changes Nov 1, 2023
View reviewed changes
@github-actions github-actions bot temporarily deployed to pull request November 1, 2023 17:56 Inactive
@jenndiaz jenndiaz added the run_vrt For use on PRs looking to kick off VRT label Nov 1, 2023
@github-actions github-actions bot temporarily deployed to pull request November 1, 2023 18:46 Inactive
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Nov 1, 2023
@github-actions github-actions bot temporarily deployed to pull request November 1, 2023 19:49 Inactive
@jenndiaz jenndiaz added the run_vrt For use on PRs looking to kick off VRT label Nov 2, 2023
@github-actions github-actions bot temporarily deployed to pull request November 2, 2023 16:28 Inactive
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Nov 2, 2023
jenndiaz added 19 commits November 2, 2023 10:34
@jenndiaz
chore(assetcard): build changes
130009e
@jenndiaz
chore(assetcard): new tokens borders and bg
d6bcb04
@jenndiaz
chore(assetcard): use all new tokens
c684fe8
@jenndiaz
fix(assetcard): correct mods
0d98d40
@jenndiaz
docs(assetcard): adds alt text
83956f4
@jenndiaz
docs(assetcard): adds input label
95ac832
@jenndiaz
fix(assestcard): alt text to storybook
c3492bc
@jenndiaz
feat(assetcard): a11y labels in story
2160bd6
@jenndiaz
feat(assetcard): whcm
6802d1b
@jenndiaz
chore(assetcard): regen mods
b9530e2
@jenndiaz
chore(assetcard): use display over visibility
8234d55
@jenndiaz
feat(assetcard): adjust custom token values
22a6061
@jenndiaz
fix(assetcard): drop target storybook
0311173
@jenndiaz
fix(assetcard): drop target story style
e1df768
@jenndiaz
fix(assetcard): storybook themes values
e6db2b4
@jenndiaz
fix(assetcard): addresses PR feedback
1af9816
@jenndiaz
feat(assetcard): add cjk typography support
4c65cc6
@jenndiaz
fix(assetcard): remove cjk properties without tokens
ae2e3c3
@jenndiaz
chore(assetcard): update dependencies
3929b17
@jenndiaz jenndiaz force-pushed the jenndiaz/css-519-asset-card-migration branch from cddbe7d to 3929b17 Compare November 2, 2023 16:34
@github-actions github-actions bot temporarily deployed to pull request November 2, 2023 16:40 Inactive
@castastrophe castastrophe added the run_vrt For use on PRs looking to kick off VRT label Nov 2, 2023
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Nov 2, 2023
@mdt2 mdt2 mentioned this pull request Nov 2, 2023
Merged
15 tasks
@castastrophe castastrophe merged commit a0cf37b into main Nov 2, 2023
@castastrophe castastrophe deleted the jenndiaz/css-519-asset-card-migration branch November 2, 2023 17:13
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
Merged
@github-actions github-actions bot mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castastrophe castastrophe castastrophe approved these changes

@pfulton pfulton Awaiting requested review from pfulton

@jawinn jawinn Awaiting requested review from jawinn

@mdt2 mdt2 Awaiting requested review from mdt2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenndiaz @pfulton @castastrophe