Skip to content

chore(tokens): add custom tokens for dropindicator, assetlist, treeview #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 8, 2023
Merged

chore(tokens): add custom tokens for dropindicator, assetlist, treeview #2228

merged 6 commits into from
Nov 8, 2023

Conversation

jenndiaz
Copy link
Contributor

@jenndiaz jenndiaz commented Oct 24, 2023 •
edited by jawinn
Loading

Description

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Adds tokens from:

Regression testing

Validate:

  1. A legacy documentation page (such as accordion), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive
  1. A migrated documentation page (such as action group), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive

Screenshots

To-do list

  • I have read the contribution guidelines.

  • I have updated relevant storybook stories and templates.

  • I have tested these changes in Windows High Contrast mode.

  • If my change impacts other components, I have tested to make sure they don't break.

  • If my change impacts documentation, I have updated the documentation accordingly.

  • ✨ This pull request is ready to merge. ✨

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023 •
edited
Loading

🚀 Deployed on https://pr-2228--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 24, 2023 15:38 Inactive
@jenndiaz jenndiaz changed the title chore(tokens): adds custom tokens for datepicker dropindicator and assetlist chore(tokens): adds custom tokens for dropindicator and assetlist Oct 24, 2023
@github-actions github-actions bot temporarily deployed to pull request October 24, 2023 16:51 Inactive
@mdt2 mdt2 changed the title chore(tokens): adds custom tokens for dropindicator and assetlist chore(tokens): add custom tokens for dropindicator, assetlist, treeview, assetcard Nov 2, 2023
@mdt2 mdt2 changed the title chore(tokens): add custom tokens for dropindicator, assetlist, treeview, assetcard chore(tokens): add custom tokens for dropindicator, datepicker, assetlist, treeview, assetcard Nov 2, 2023
@mdt2 mdt2 changed the title chore(tokens): add custom tokens for dropindicator, datepicker, assetlist, treeview, assetcard chore(tokens): add custom tokens for dropindicator, assetlist, treeview, assetcard Nov 2, 2023
@mdt2 mdt2 requested review from jawinn and pfulton November 2, 2023 17:03
@mdt2 mdt2 force-pushed the jenndiaz/custom-tokens-batch branch from 48c0511 to 8bc06d5 Compare November 2, 2023 17:04
@mdt2 mdt2 marked this pull request as ready for review November 2, 2023 17:05
@github-actions github-actions bot temporarily deployed to pull request November 2, 2023 17:09 Inactive
@mdt2 mdt2 force-pushed the jenndiaz/custom-tokens-batch branch 2 times, most recently from 6882775 to 2082da1 Compare November 2, 2023 19:36
@mdt2 mdt2 changed the title chore(tokens): add custom tokens for dropindicator, assetlist, treeview, assetcard chore(tokens): add custom tokens for dropindicator, assetlist, treeview Nov 2, 2023
@github-actions github-actions bot temporarily deployed to pull request November 2, 2023 19:43 Inactive
@jenndiaz jenndiaz force-pushed the jenndiaz/custom-tokens-batch branch from 2082da1 to 8e64d78 Compare November 3, 2023 21:03
@github-actions github-actions bot temporarily deployed to pull request November 3, 2023 21:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 3, 2023 21:26 Inactive
@pfulton pfulton force-pushed the jenndiaz/custom-tokens-batch branch from 3bdaf4e to ccbb75c Compare November 6, 2023 14:51
@github-actions github-actions bot temporarily deployed to pull request November 6, 2023 14:55 Inactive
@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label Nov 6, 2023
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Nov 6, 2023
@pfulton pfulton force-pushed the jenndiaz/custom-tokens-batch branch from ccbb75c to 78660df Compare November 8, 2023 15:17
@github-actions github-actions bot temporarily deployed to pull request November 8, 2023 15:22 Inactive
@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label Nov 8, 2023
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Nov 8, 2023
@pfulton pfulton merged commit 07187f7 into main Nov 8, 2023
@pfulton pfulton deleted the jenndiaz/custom-tokens-batch branch November 8, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawinn jawinn jawinn approved these changes

@pfulton pfulton Awaiting requested review from pfulton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenndiaz @jawinn @pfulton