Skip to content

refactor(assetlist)!: migrate to spectrum tokens #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 8, 2023

Conversation

jenndiaz
Copy link
Contributor

@jenndiaz jenndiaz commented Oct 12, 2023

Description

Migrates AssetList to spectrum tokens

  • addresses empty label a11y issue (on docs site, storybook, and within Miller Column)
  • Adds is-navigated AssetList-Item to docs site
  • Adds WCHM values
  • Addresses previous issue with text color on dark and darkest and focus indicators

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Test Outline:

@jawinn

  1. Open the docs site for the asset list component:
  • there is a 4th asset item, Downloads with is-navigated styling
  • Tabbing through there is a focus indicator
  • component contrast is appropriate for all color themes (light, dark, darkest)
  • a11y testing has an accessible name for each check box
  1. Open the storybook for the asset list component:
  • there are no a11y violations
  • Hover, selected, and navigated all match docs site

Regression testing

Validate:

  1. A legacy documentation page (such as accordion), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive
  1. A migrated documentation page (such as action group), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive

Screenshots

To-do list

  • I have read the contribution guidelines.

  • I have updated relevant storybook stories and templates.

  • I have tested these changes in Windows High Contrast mode.

  • If my change impacts other components, I have tested to make sure they don't break.

  • If my change impacts documentation, I have updated the documentation accordingly.

  • ✨ This pull request is ready to merge. ✨

@jenndiaz jenndiaz force-pushed the jenndiaz/css-517-assest-list-migration branch 2 times, most recently from 59471dc to 3288213 Compare October 16, 2023 18:49
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

🚀 Deployed on https://pr-2211--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 16, 2023 18:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 16, 2023 22:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 16, 2023 23:29 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 17, 2023 20:49 Inactive
@jenndiaz jenndiaz marked this pull request as ready for review October 17, 2023 21:08
@jenndiaz jenndiaz requested review from pfulton, mdt2 and jawinn October 17, 2023 21:08
Copy link
Collaborator

@jawinn jawinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with this, including the accessibility fixes! I've confirmed the validation steps and everything looks right, and improved.

I don't think --spectrum-assetlist-checkbox-margin is used, so that can probably be removed?

My only suggestion would be to pass an id into the Checkbox story in Storybook, as Chrome console shows a recommendation about it not having an id or name (while also saying it's not strictly necessary)---the docs examples do already have an ID on them, so that would help align the markup.

@jenndiaz jenndiaz added the run_vrt For use on PRs looking to kick off VRT label Oct 20, 2023
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Oct 20, 2023
@github-actions github-actions bot temporarily deployed to pull request October 23, 2023 19:03 Inactive
@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label Nov 1, 2023
Copy link
Collaborator

@pfulton pfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement on dark and darkest which look broken in production...

Thanks for taking care of this!

@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Nov 1, 2023
@jenndiaz jenndiaz force-pushed the jenndiaz/css-517-assest-list-migration branch from bd29e4a to 99767dd Compare November 8, 2023 16:21
@github-actions github-actions bot temporarily deployed to pull request November 8, 2023 16:26 Inactive
@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label Nov 8, 2023
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Nov 8, 2023
@pfulton pfulton merged commit 32149e5 into main Nov 8, 2023
@pfulton pfulton deleted the jenndiaz/css-517-assest-list-migration branch November 8, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants