Skip to content

feat(clearbutton)!: migrate tokens #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 17, 2023
Merged

feat(clearbutton)!: migrate tokens #1943

merged 13 commits into from
Aug 17, 2023

Conversation

mlogsdon18
Copy link
Contributor

@mlogsdon18 mlogsdon18 commented Jun 16, 2023 •
edited
Loading

Description

This PR migrates the tokens for the Clear Button based on the design file for In-field Button

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested these changes in Windows High Contrast mode.
  • I have updated any relevant storybook stories and templates.
  • If my change(s) include visual change(s), a designer has reviewed and approved those changes.
  • In-field tokens have been added to the main tokens release
  • This pull request is ready to merge.

@mlogsdon18 mlogsdon18 added tokens CSS Custom Properties of or relating to Spectrum Tokens do not merge A flag for a branch indicating it should not be merged. labels Jun 16, 2023
@mlogsdon18 mlogsdon18 force-pushed the css-515-clear-button-tokens branch from 25dd0af to 7c00749 Compare June 21, 2023 19:06
@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2023 •
edited
Loading

🚀 Deployed on https://pr-1943--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 21, 2023 19:14 Inactive
jenndiaz
jenndiaz suggested changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@jenndiaz jenndiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with each of these, 🙌 just couple of comments on this one!

@mlogsdon18 mlogsdon18 force-pushed the css-515-clear-button-tokens branch from 7c00749 to c25116b Compare June 26, 2023 16:53
@github-actions github-actions bot temporarily deployed to pull request June 26, 2023 17:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 26, 2023 17:29 Inactive
@mlogsdon18 mlogsdon18 force-pushed the css-515-clear-button-tokens branch 2 times, most recently from 77caa1f to 26811a2 Compare June 28, 2023 18:27
@github-actions github-actions bot temporarily deployed to pull request June 28, 2023 18:34 Inactive
@mlogsdon18 mlogsdon18 force-pushed the css-515-clear-button-tokens branch from 26811a2 to 07edb3e Compare June 30, 2023 19:05
@github-actions github-actions bot temporarily deployed to pull request June 30, 2023 19:13 Inactive
@mlogsdon18 mlogsdon18 force-pushed the css-515-clear-button-tokens branch from 07edb3e to 32cac1f Compare July 3, 2023 19:53
@github-actions github-actions bot temporarily deployed to pull request July 3, 2023 20:00 Inactive
@mlogsdon18 mlogsdon18 force-pushed the css-515-clear-button-tokens branch from 32cac1f to 343a785 Compare July 7, 2023 17:54
@github-actions github-actions bot temporarily deployed to pull request July 7, 2023 18:02 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 10, 2023 14:12 Inactive
@mlogsdon18 mlogsdon18 force-pushed the css-515-clear-button-tokens branch from 6e64034 to 2139d76 Compare July 12, 2023 12:42
@github-actions github-actions bot temporarily deployed to pull request July 12, 2023 12:49 Inactive
@mlogsdon18 mlogsdon18 force-pushed the css-515-clear-button-tokens branch from 2139d76 to 1d65549 Compare July 13, 2023 13:15
@github-actions github-actions bot temporarily deployed to pull request July 13, 2023 13:23 Inactive
@mlogsdon18 mlogsdon18 added run_vrt For use on PRs looking to kick off VRT and removed tokens CSS Custom Properties of or relating to Spectrum Tokens do not merge A flag for a branch indicating it should not be merged. labels Jul 17, 2023
@mlogsdon18 mlogsdon18 force-pushed the css-515-clear-button-tokens branch from 77efdd6 to 0e3876e Compare July 17, 2023 12:28
@github-actions github-actions bot temporarily deployed to pull request July 17, 2023 12:35 Inactive
@mlogsdon18 mlogsdon18 force-pushed the css-515-clear-button-tokens branch from 0e3876e to e4f7a05 Compare July 18, 2023 14:17
@github-actions github-actions bot temporarily deployed to pull request July 18, 2023 14:24 Inactive
@mlogsdon18 mlogsdon18 force-pushed the css-515-clear-button-tokens branch from 6b01683 to 2261df6 Compare August 16, 2023 14:28
@github-actions github-actions bot temporarily deployed to pull request August 16, 2023 14:34 Inactive
@mlogsdon18 mlogsdon18 force-pushed the css-515-clear-button-tokens branch from 2261df6 to 07919d6 Compare August 17, 2023 13:47
@github-actions github-actions bot temporarily deployed to pull request August 17, 2023 13:53 Inactive
castastrophe
castastrophe approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we merge let's align the dependencies to current versions and we should be all set.

@mlogsdon18
Copy link
Contributor Author

Approval on the SWC side! adobe/spectrum-web-components#3476 (comment)

@mlogsdon18 mlogsdon18 requested a review from jenndiaz August 17, 2023 14:35
@github-actions github-actions bot temporarily deployed to pull request August 17, 2023 14:42 Inactive
jenndiaz
jenndiaz approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@jenndiaz jenndiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

mlogsdon18 and others added 13 commits August 17, 2023 11:21
@mlogsdon18 mlogsdon18 force-pushed the css-515-clear-button-tokens branch from 46f8e5d to c0cc44b Compare August 17, 2023 15:22
@github-actions github-actions bot temporarily deployed to pull request August 17, 2023 15:30 Inactive
@castastrophe castastrophe added run_vrt For use on PRs looking to kick off VRT and removed pending-swc-validation labels Aug 17, 2023
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Aug 17, 2023
@castastrophe castastrophe merged commit 495198a into main Aug 17, 2023
@castastrophe castastrophe deleted the css-515-clear-button-tokens branch August 17, 2023 17:03
@rise-erpelding rise-erpelding mentioned this pull request Oct 18, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castastrophe castastrophe castastrophe approved these changes

@jenndiaz jenndiaz jenndiaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlogsdon18 @pfulton @castastrophe @jenndiaz