-
Notifications
You must be signed in to change notification settings - Fork 201
fix(clear button): align background color and hover state for disabled variant #3258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 1042098 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Deployed on https://pr-3258--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.30 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailsclearbutton
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
ce33d1e
to
0487ad5
Compare
0487ad5
to
5f2ca66
Compare
5f2ca66
to
7e137f2
Compare
13f8de8
to
b2ba05b
Compare
1ad374c
to
f628399
Compare
7c2fd07
to
5df066e
Compare
5df066e
to
a3c8585
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YOU CAN SEE THE DISABLED BUTTON! 🎉 Left a couple of questions for you, but it looks really great!
fd9b15e
to
2d9742c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for digging into this one!
a700d10
to
0a09890
Compare
8608abd
to
8e9ad80
Compare
8e9ad80
to
1042098
Compare
Description
More closely aligns the clear button styling with the close button styling by adopting the pattern of classes targeting the disabled state. Scopes hover indicators to components that are not disabled and aligns the disabled colors used by the two components.
How and where has this been tested?
Locally in storybook.
Validation steps
Regression testing
Validate:
Screenshots
To-do list