Skip to content

fix(clear button): align background color and hover state for disabled variant #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 28, 2024

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Oct 15, 2024

Description

More closely aligns the clear button styling with the close button styling by adopting the pattern of classes targeting the disabled state. Scopes hover indicators to components that are not disabled and aligns the disabled colors used by the two components.

How and where has this been tested?

Locally in storybook.

Validation steps

  1. Fetch the branch and run it locally or access the Storybook URL for the branch.
  2. Navigate to the clear button component and toggle on the disabled state.
  3. Do the same for the close button.
  4. Verify that the two are visually consistent.

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

Screenshot 2024-10-15 at 10 39 50 AM

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@cdransf cdransf added the skip_vrt Add to a PR to skip running VRT (but still pass the action) label Oct 15, 2024
@cdransf cdransf self-assigned this Oct 15, 2024
Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: 1042098

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/clearbutton Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 15, 2024

🚀 Deployed on https://pr-3258--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Oct 15, 2024

File metrics

Summary

Total size: 4.30 MB*
Total change (Δ): 🔴 ⬆ 2.25 KB (0.05%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
clearbutton 7.56 KB 🔴 ⬆ 0.77 KB

Details

clearbutton

Filename Head Compared to base
index-base.css 6.77 KB 🔴 ⬆ 0.77 KB (12.46%)
index-theme.css 1.40 KB -
index-vars.css 7.56 KB 🔴 ⬆ 0.77 KB (11.02%)
index.css 7.56 KB 🔴 ⬆ 0.77 KB (11.02%)
themes/express.css 1.03 KB -
themes/spectrum.css 1.00 KB -
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@cdransf cdransf force-pushed the cdransf/clear-button-fixes branch 3 times, most recently from ce33d1e to 0487ad5 Compare October 16, 2024 17:40
@cdransf cdransf marked this pull request as ready for review October 16, 2024 17:56
@cdransf cdransf added run_vrt For use on PRs looking to kick off VRT ready-for-review and removed skip_vrt Add to a PR to skip running VRT (but still pass the action) labels Oct 16, 2024
@cdransf cdransf force-pushed the cdransf/clear-button-fixes branch from 0487ad5 to 5f2ca66 Compare October 16, 2024 18:25
@adobe adobe deleted a comment from github-actions bot Oct 16, 2024
@adobe adobe deleted a comment from github-actions bot Oct 16, 2024
@cdransf cdransf force-pushed the cdransf/clear-button-fixes branch from 5f2ca66 to 7e137f2 Compare October 16, 2024 19:48
@adobe adobe deleted a comment from github-actions bot Oct 16, 2024
@adobe adobe deleted a comment from github-actions bot Oct 16, 2024
@cdransf cdransf force-pushed the cdransf/clear-button-fixes branch 3 times, most recently from 13f8de8 to b2ba05b Compare October 16, 2024 20:23
@cdransf cdransf added skip_vrt Add to a PR to skip running VRT (but still pass the action) and removed run_vrt For use on PRs looking to kick off VRT labels Oct 16, 2024
@cdransf cdransf force-pushed the cdransf/clear-button-fixes branch 3 times, most recently from 1ad374c to f628399 Compare October 17, 2024 22:28
@cdransf cdransf added the size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. label Oct 17, 2024
@cdransf cdransf added the run_vrt For use on PRs looking to kick off VRT label Oct 23, 2024
@cdransf cdransf force-pushed the cdransf/clear-button-fixes branch from 7c2fd07 to 5df066e Compare October 23, 2024 16:38
@cdransf cdransf force-pushed the cdransf/clear-button-fixes branch from 5df066e to a3c8585 Compare October 23, 2024 18:46
Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOU CAN SEE THE DISABLED BUTTON! 🎉 Left a couple of questions for you, but it looks really great!

@cdransf cdransf force-pushed the cdransf/clear-button-fixes branch 2 times, most recently from fd9b15e to 2d9742c Compare October 24, 2024 20:49
Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this one!

@cdransf cdransf force-pushed the cdransf/clear-button-fixes branch 3 times, most recently from a700d10 to 0a09890 Compare October 28, 2024 17:10
@cdransf cdransf force-pushed the cdransf/clear-button-fixes branch 2 times, most recently from 8608abd to 8e9ad80 Compare October 28, 2024 18:15
@cdransf cdransf force-pushed the cdransf/clear-button-fixes branch from 8e9ad80 to 1042098 Compare October 28, 2024 18:24
@cdransf cdransf merged commit db450d8 into main Oct 28, 2024
14 checks passed
@cdransf cdransf deleted the cdransf/clear-button-fixes branch October 28, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review run_vrt For use on PRs looking to kick off VRT size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants