Skip to content

refactor(checkbox): remove commented out code #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

pfulton
Copy link
Collaborator

@pfulton pfulton commented Oct 4, 2022

Description

I accidentally left this chunk of commented-out code in the CSS. This PR removes it.

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with:

Screenshots

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested these changes in Windows High Contrast mode.
  • This pull request is ready to merge.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

🚀 Deployed on https://pr-1524--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 4, 2022 19:51 Inactive
@pfulton pfulton force-pushed the pfulton/refactor--checkbox-comments branch from aef5b3d to bdb3ae7 Compare October 4, 2022 20:24
@github-actions github-actions bot temporarily deployed to pull request October 4, 2022 20:28 Inactive
@pfulton pfulton merged commit 64b0b64 into main Oct 4, 2022
@pfulton pfulton deleted the pfulton/refactor--checkbox-comments branch October 4, 2022 21:03
bernhard-adobe added a commit that referenced this pull request Oct 12, 2022
* main: (53 commits)
  chore(release): release
  fix(checkbox): whcm focus states (#1527)
  chore(release): release
  feat(fieldlabel)!: migrate to core tokens (CSS-102) (#1476)
  chore(release): release
  feat(swatchgroup)!: migrate swatchgroup to core tokens (#1505)
  chore(release): release
  feat(swatch)!: migrate swatch to core tokens (#1501)
  chore(release): release
  fix(tabs): selection indicator scroll overflow border (#1513)
  chore(release): release
  feat(divider)!: migrate to core tokens
  chore(release): release
  refactor(checkbox): remove commented out code (#1524)
  chore(release): release
  feat(progresscircle)!: migrate to core tokens
  chore(release): release
  feat(checkbox)!: migrate checkbox component to core tokens (CSS-99) (#1465)
  chore(release): release
  fix(card): increase content area height when necessary
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant