Skip to content

feat(swatchgroup)!: migrate swatchgroup to core tokens #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 6, 2022

Conversation

yosevu
Copy link
Contributor

@yosevu yosevu commented Aug 19, 2022

Description

This was a really simple one.

  • Update spacing tokens

How and where has this been tested?

Tested locally referencing the SwatchGroup XD file.

Screenshots

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested these changes in Windows High Contrast mode.
  • This pull request is ready to merge.

@yosevu yosevu requested a review from lunarfusion August 22, 2022 21:53
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2022

🚀 Deployed on https://pr-1505--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 22, 2022 21:56 Inactive
@bernhard-adobe
Copy link
Contributor

Copy link
Contributor

@bernhard-adobe bernhard-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@yosevu yosevu force-pushed the yosevu/css-151-migrate-swatchgroup-to-core-tokens branch from c022819 to 396b201 Compare August 23, 2022 22:01
@github-actions github-actions bot temporarily deployed to pull request August 23, 2022 22:06 Inactive
@yosevu yosevu requested a review from lunarfusion August 24, 2022 20:13
Copy link
Contributor

@lunarfusion lunarfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pfulton
Copy link
Collaborator

pfulton commented Aug 30, 2022

Released beta:
2.0.0-beta.0

@yosevu can you open a PR in the Spectrum Web Components repo with this update?

@pfulton pfulton force-pushed the yosevu/css-151-migrate-swatchgroup-to-core-tokens branch from 628587c to f3ff88e Compare October 6, 2022 21:32
@github-actions github-actions bot temporarily deployed to pull request October 6, 2022 21:36 Inactive
@pfulton pfulton merged commit 7a0daf4 into main Oct 6, 2022
@pfulton pfulton deleted the yosevu/css-151-migrate-swatchgroup-to-core-tokens branch October 6, 2022 21:38
bernhard-adobe added a commit that referenced this pull request Oct 12, 2022
* main: (53 commits)
  chore(release): release
  fix(checkbox): whcm focus states (#1527)
  chore(release): release
  feat(fieldlabel)!: migrate to core tokens (CSS-102) (#1476)
  chore(release): release
  feat(swatchgroup)!: migrate swatchgroup to core tokens (#1505)
  chore(release): release
  feat(swatch)!: migrate swatch to core tokens (#1501)
  chore(release): release
  fix(tabs): selection indicator scroll overflow border (#1513)
  chore(release): release
  feat(divider)!: migrate to core tokens
  chore(release): release
  refactor(checkbox): remove commented out code (#1524)
  chore(release): release
  feat(progresscircle)!: migrate to core tokens
  chore(release): release
  feat(checkbox)!: migrate checkbox component to core tokens (CSS-99) (#1465)
  chore(release): release
  fix(card): increase content area height when necessary
  ...
bernhard-adobe added a commit that referenced this pull request Oct 14, 2022
* main: (65 commits)
  chore(release): release
  chore!: use latest CSS tokens dependency
  refactor(swatch)!: remap core token aliases & rename aliases
  refactor(helptext)!: remap core token aliases & rename aliases
  refactor(radio)!: remap core token aliases & rename aliases
  refactor(checkbox)!: remap core token aliases & rename aliases
  refactor(switch)!: remap core token aliases & rename aliases
  refactor(actionbutton)!: remap core token aliases & rename aliases
  refactor(closebutton)!: remap core token aliases & rename aliases
  feat(tokens)!: use latest beta release
  chore(release): release
  refactor(inlinealert)!: migrate to core tokens (#1519)
  chore(release): release
  fix(checkbox): whcm focus states (#1527)
  chore(release): release
  feat(fieldlabel)!: migrate to core tokens (CSS-102) (#1476)
  chore(release): release
  feat(swatchgroup)!: migrate swatchgroup to core tokens (#1505)
  chore(release): release
  feat(swatch)!: migrate swatch to core tokens (#1501)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants