Skip to content

Conversation

@yihuiliao
Copy link
Member

@yihuiliao yihuiliao commented Dec 9, 2025

Chromatic:
https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=1082

Some things to note:

  1. The notification badges have shifted a little bit but it's pretty minimal
  2. ToggleButton's truncate to fit inside the container. It seems that previously, the button would exceed the grid but now it truncates to fit. This change is okay

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

For Action button stories, use dev tools to add flex-direction: column on the flex container and set up a specific width. The action buttons should not stretch to fit the container.

Also within dev tools, set a width on the action buttons and it should expand accordingly. For the notification badge, they should still positioned correctly.

🧢 Your Project:

@rspbot
Copy link

rspbot commented Dec 9, 2025

@yihuiliao yihuiliao added this pull request to the merge queue Dec 9, 2025
Merged via the queue into main with commit 848fc8b Dec 9, 2025
36 checks passed
@yihuiliao yihuiliao deleted the notification-badge-s2 branch December 9, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants